From: Christophe Lyon <christophe.lyon@linaro.org>
To: buildbot@sourceware.org
Cc: Christophe Lyon <christophe.lyon@linaro.org>
Subject: [PATCH 1/5] autoregen.py: enable autoreconf for gcc, libdecnumber, libiberty, libobjc
Date: Wed, 17 Apr 2024 14:50:29 +0000 [thread overview]
Message-ID: <20240417145033.2077525-1-christophe.lyon@linaro.org> (raw)
Calling just 'autoreconf' works well for these subdirs despite the
absence of Makefile.am: there's no real need to provide -I xxxx flags
when calling aclocal, the generated files are the same.
It does make a difference for gcc and libobjc however: some warnings
are printed by autoreconf, because additional .m4 files are parsed in
a different order by plain 'aclocal' and 'aclocal -I xxx'.
We can accept that for the buildbot, for the sake of simplicity of
this helper, but that may confuse users.
---
builder/containers/autoregen.py | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/builder/containers/autoregen.py b/builder/containers/autoregen.py
index 64d132e..38cbdae 100755
--- a/builder/containers/autoregen.py
+++ b/builder/containers/autoregen.py
@@ -73,7 +73,7 @@ AUTORECONF_DIRS = [
# gcc subdirs
"c++tools", # No aclocal.m4
- #"gcc", # No Makefile.am
+ "gcc", # No Makefile.am
#"fixincludes", # autoreconf complains about GCC_AC_FUNC_MMAP_BLACKLIST
"gnattools", # No aclocal.m4
"gotools",
@@ -83,7 +83,7 @@ AUTORECONF_DIRS = [
"libcc1",
"libcody", # No aclocal.m4
#"libcpp", # No Makefile.am
- #"libdecnumber", # No Makefile.am
+ "libdecnumber", # No Makefile.am
"libffi",
"libgcc", # No aclocal.m4
"libgfortran",
@@ -94,9 +94,9 @@ AUTORECONF_DIRS = [
"libgo",
"libgomp",
"libgrust",
- #"libiberty", # No Makefile.am
+ "libiberty", # No Makefile.am
"libitm",
- #"libobjc", # No Makefile.am
+ "libobjc", # No Makefile.am
"libphobos",
"libquadmath",
"libsanitizer",
@@ -149,7 +149,7 @@ def regenerate_manually():
include_arg = "-I.."
include_arg2 = "-I../config"
- if folder.stem == "libgm2" or folder.stem == "gcc" or folder.stem == "libiberty" or folder.stem == "libobjc":
+ if folder.stem == "libgm2":
include_arg = "-I../config"
include_arg2 = "-I.."
--
2.34.1
next reply other threads:[~2024-04-17 14:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 14:50 Christophe Lyon [this message]
2024-04-17 14:50 ` [PATCH 2/5] autoregen.py: Move subdirs common to binutils-gdb and gcc Christophe Lyon
2024-04-17 14:50 ` [PATCH 3/5] autoregen.py: improve comment Christophe Lyon
2024-04-17 14:50 ` [PATCH 4/5] autoregen.py: libcpp can use autoreconf Christophe Lyon
2024-04-18 21:46 ` Mark Wielaard
2024-04-19 8:20 ` Christophe Lyon
2024-04-17 14:50 ` [PATCH 5/5] autoregen.py: Add introduction comment Christophe Lyon
2024-04-17 15:12 ` Simon Marchi
2024-04-18 9:59 ` Christophe Lyon
2024-04-18 21:55 ` Mark Wielaard
2024-04-19 8:22 ` Christophe Lyon
2024-04-18 21:53 ` [PATCH 1/5] autoregen.py: enable autoreconf for gcc, libdecnumber, libiberty, libobjc Mark Wielaard
2024-04-19 8:21 ` Christophe Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240417145033.2077525-1-christophe.lyon@linaro.org \
--to=christophe.lyon@linaro.org \
--cc=buildbot@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).