From: Cesar Philippidis <cesar@codesourcery.com>
To: Thomas Schwinge <thomas@codesourcery.com>, <gcc-patches@gcc.gnu.org>
Subject: Re: Repeated use of the OpenACC routine directive
Date: Thu, 18 Aug 2016 22:08:00 -0000 [thread overview]
Message-ID: <2d9f712a-0972-bfd0-d9c4-f95f22fd9435@codesourcery.com> (raw)
In-Reply-To: <877fbggq7i.fsf@hertz.schwinge.homeip.net>
On 08/16/2016 06:05 PM, Thomas Schwinge wrote:
> commit bffb0ee6c0a83b8c85cd919e1172086b51fdc452
> Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
> Date: Wed Aug 17 00:55:02 2016 +0000
>
> Repeated use of the C/C++ OpenACC routine directive
>
> gcc/
> * omp-low.c (verify_oacc_routine_clauses): Change formal
> parameters. Add checking if already marked as an accelerator
> routine. Adjust all users.
> gcc/c/
> * c-parser.c (c_finish_oacc_routine): Rework checking if already
> marked as an accelerator routine.
> gcc/cp/
> * parser.c (cp_finalize_oacc_routine): Rework checking if already
> marked as an accelerator routine.
> gcc/testsuite/
> * c-c++-common/goacc/oaccdevlow-routine.c: Update.
This test case is missing in both gomp4 and the git diff --stat below.
Cesar
> * c-c++-common/goacc/routine-5.c: Likewise.
> * c-c++-common/goacc/routine-level-of-parallelism-1.c: Likewise.
> * c-c++-common/goacc/routine-level-of-parallelism-2.c: New file.
>
> gcc/testsuite/
> * c-c++-common/goacc/routine-1.c: Update.
> * c-c++-common/goacc/routine-2.c: Likewise.
> * c-c++-common/goacc/routine-nohost-1.c: Likewise.
> * g++.dg/goacc/routine-2.C: Likewise.
> * c-c++-common/goacc/routine-nohost-2.c: New file.
>
> git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@239521 138bc75d-0d04-0410-961f-82ee72b054a4
> ---
> gcc/ChangeLog.gomp | 4 +
> gcc/c/ChangeLog.gomp | 3 +
> gcc/c/c-parser.c | 42 ++--
> gcc/cp/ChangeLog.gomp | 3 +
> gcc/cp/parser.c | 51 +++--
> gcc/omp-low.c | 146 ++++++++++++-
> gcc/omp-low.h | 2 +-
> gcc/testsuite/ChangeLog.gomp | 11 +
> gcc/testsuite/c-c++-common/goacc/routine-1.c | 51 ++++-
> gcc/testsuite/c-c++-common/goacc/routine-2.c | 143 +++++++++++++
> gcc/testsuite/c-c++-common/goacc/routine-5.c | 46 +---
> .../goacc/routine-level-of-parallelism-1.c | 233 ++++++++++++++++++---
> .../goacc/routine-level-of-parallelism-2.c | 73 +++++++
> .../c-c++-common/goacc/routine-nohost-1.c | 20 ++
> .../c-c++-common/goacc/routine-nohost-2.c | 97 +++++++++
> gcc/testsuite/g++.dg/goacc/routine-2.C | 9 +
> 16 files changed, 816 insertions(+), 118 deletions(-)
next prev parent reply other threads:[~2016-08-18 22:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 15:21 Use verify_oacc_routine_clauses for C/C++ Thomas Schwinge
2016-08-01 15:30 ` Use verify_oacc_routine_clauses for Fortran (was: Use verify_oacc_routine_clauses for C/C++) Thomas Schwinge
2016-08-09 15:55 ` Cesar Philippidis
2016-08-10 11:46 ` Thomas Schwinge
2016-08-17 1:02 ` Use verify_oacc_routine_clauses for C/C++ Thomas Schwinge
2018-10-02 14:12 ` [patch,openacc] Use oacc_verify_routine_clauses " Cesar Philippidis
2016-08-01 15:51 ` Repeated use of the OpenACC routine directive Thomas Schwinge
2016-08-17 1:05 ` Thomas Schwinge
2016-08-18 22:08 ` Cesar Philippidis [this message]
2016-08-19 14:39 ` Cesar Philippidis
2018-10-02 14:57 ` [patch,openacc] " Cesar Philippidis
2019-02-22 12:25 ` PR89433 "Repeated use of the OpenACC 'routine' directive" Thomas Schwinge
2019-05-17 19:17 ` [committed] " Thomas Schwinge
2020-03-04 19:27 ` [PATCH] Handle 'omp declare target' attribute set for both OpenACC and OpenMP 'target' [PR89433, PR93465] (was: [committed] PR89433 "Repeated use of the OpenACC 'routine' directive") Thomas Schwinge
2020-03-04 20:09 ` Jakub Jelinek
2020-04-10 14:14 ` [PATCH] Handle 'omp declare target' attribute set for both OpenACC and OpenMP 'target' [PR89433, PR93465] Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d9f712a-0972-bfd0-d9c4-f95f22fd9435@codesourcery.com \
--to=cesar@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).