From: "Kévin Le Gouguec" <legouguec@adacore.com>
To: "Arsen Arsenović" <arsen@aarsen.me>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 0/3] Recover in-tree libiconv build support
Date: Thu, 18 Apr 2024 18:41:27 +0200 [thread overview]
Message-ID: <87wmoud3ns.fsf@adacore.com> (raw)
In-Reply-To: <20240414001113.1698685-1-arsen@aarsen.me> ("Arsen =?utf-8?Q?Arsenovi=C4=87=22's?= message of "Sat, 13 Apr 2024 23:58:01 +0200")
Arsen Arsenović <arsen@aarsen.me> writes:
> Evening!
>
> This patchset recovers support for building the toolchain tree with
> in-tree libiconv being used for host modules and gettext. As spotted by
> Kévin Le Gouguec <legouguec@adacore.com>, I accidentally removed this
> functionality earlier.
>
> This patchset includes the patch sent as:
>
> https://inbox.sourceware.gcc-patches/20231221193243.368541-1-arsen@aarsen.me/
>
> ... and so, supersedes that patchset.
>
> For the in-tree case, the old patch functionality was restored and
> rebased on top of current iconv.m4. Of course, this does not work for
> gettext, an out-of-tree lib depending on the in-tree libiconv, so, for
> that case, we needed to provide the right information to configure, and
> suppress logic in iconv.m4 using cache vars.
>
> Build-tested on arm64-apple-darwin21.6.0, and I intend to do further
> testing tomorrow.
>
> OK for trunk? It would be good to get these patches into GCC 14.
>
> I apologize for being quite late with delivering these, I have,
> unfortunately, been busied by various external factors. Hopefully, it
> is not too late yet.
FWIW, I apologize too for not taking a stab at the fix; on our end, we
pondered this briefly and figured we had no compelling reason to
continue relying on in-tree libiconv builds, so we tweaked our packaging
recipes to configure --with-libiconv-prefix and that was that.
Thanks for finding the time to work on this!
next prev parent reply other threads:[~2024-04-18 16:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 21:58 Arsen Arsenović
2024-04-13 21:58 ` [PATCH 1/3] toplevel: don't override gettext-runtime/configure-discovered build args Arsen Arsenović
2024-04-13 21:58 ` [PATCH 2/3] gitignore: ignore /libiconv* Arsen Arsenović
2024-04-13 21:58 ` [PATCH 3/3] *: support in-tree libiconv again Arsen Arsenović
2024-04-18 16:41 ` Kévin Le Gouguec [this message]
2024-05-04 18:48 ` Ping: [PATCH 0/3] Recover in-tree libiconv build support Arsen Arsenović
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmoud3ns.fsf@adacore.com \
--to=legouguec@adacore.com \
--cc=arsen@aarsen.me \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).