From: Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com>
To: Jeff Law <law@redhat.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Francois Bedard <Francois.Bedard@synopsys.com>,
"andrew.burgess@embecosm.com" <andrew.burgess@embecosm.com>,
Shahab Vahedi <Shahab.Vahedi@synopsys.com>
Subject: RE: [PATCH] [ARC] Fix movsi_ne pattern.
Date: Wed, 30 Oct 2019 09:59:00 -0000 [thread overview]
Message-ID: <BN8PR12MB2849E066AAC1ADFC4C12725DCA600@BN8PR12MB2849.namprd12.prod.outlook.com> (raw)
In-Reply-To: <67e73c52-f49b-8ccd-6ee9-96cefb4c5b9c@redhat.com>
Hi Jeff,
> So I'm going to have to trust you on this one. It looks like you did
> more than just reorder the alternatives. For example, the constraints
> for operand0 look significantly different to me. THey're slightly
> different for operand1 as well (LR rather than Lc).
When we moved the ARC backend to LRA, we retired the register classes covered by `c` and `w` register constraints letters.
Now, all of them are pointing to the same register class like `r`.
So, whenever I have the opportunity, I also refactor the patterns not to use any longer the obsolete register constraints. Probably, this is the reason why the patch looks like it is more than reordering, but at the core it is just that :)
Thank you for your review,
Claudiu
next prev parent reply other threads:[~2019-10-30 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 8:22 Claudiu Zissulescu
2019-10-28 19:43 ` Jeff Law
2019-10-30 9:59 ` Claudiu Zissulescu [this message]
2019-10-31 16:46 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR12MB2849E066AAC1ADFC4C12725DCA600@BN8PR12MB2849.namprd12.prod.outlook.com \
--to=claudiu.zissulescu@synopsys.com \
--cc=Francois.Bedard@synopsys.com \
--cc=Shahab.Vahedi@synopsys.com \
--cc=andrew.burgess@embecosm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).