From: Xi Ruoyao <xry111@xry111.site>
To: Florian Weimer <fw@deneb.enyo.de>,
Andreas Schwab <schwab@linux-m68k.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] malloc: Remove bin scanning from memalign (bug 30723)
Date: Mon, 14 Aug 2023 10:14:11 +0800 [thread overview]
Message-ID: <ae91f53030eaeef64b02f67d890eddc503ed4da4.camel@xry111.site> (raw)
In-Reply-To: <87edk8wfl3.fsf@mid.deneb.enyo.de>
On Sat, 2023-08-12 at 15:33 +0200, Florian Weimer wrote:
> * Florian Weimer:
>
> > * Andreas Schwab:
> >
> > > malloc.c: In function '_int_free':
> > > malloc.c:4496:13: error: unused variable 'fwd' [-Werror=unused-variable]
> > > 4496 | mchunkptr fwd; /* misc temp for linking */
> > > | ^~~
> > > malloc.c:4495:13: error: unused variable 'bck' [-Werror=unused-variable]
> > > 4495 | mchunkptr bck; /* misc temp for linking */
> > > | ^~~
> > > malloc.c:4494:19: error: unused variable 'prevsize' [-Werror=unused-variable]
> > > 4494 | INTERNAL_SIZE_T prevsize; /* size of previous contiguous chunk */
> > > | ^~~~~~~~
> > > malloc.c:4493:7: error: unused variable 'nextinuse' [-Werror=unused-variable]
> > > 4493 | int nextinuse; /* true if nextchunk is used */
> > > | ^~~~~~~~~
> > > malloc.c:4492:19: error: unused variable 'nextsize' [-Werror=unused-variable]
> > > 4492 | INTERNAL_SIZE_T nextsize; /* its size */
> > > | ^~~~~~~~
> > > malloc.c:4491:13: error: unused variable 'nextchunk' [-Werror=unused-variable]
> > > 4491 | mchunkptr nextchunk; /* next contiguous chunk */
> > > | ^~~~~~~~~
> > > cc1: all warnings being treated as errors
> > > make[2]: *** [../o-iterator.mk:9: /home/abuild/rpmbuild/BUILD/glibc-2.38.9000.31.g084fb31bc2/cc-base/malloc/malloc.o] Error 1
> >
> > This is a disable-tcache configuration, right? Will fix.
>
> No, the variables are always unused. This looks like a GCC bug on my
> side. It's strange that it appears with GCC 12 and GCC 13. Which
> version do you use?
But I just removed these variables in a patched (applying
542b1105852568c3ebc712225ae78b8c8ba31a78 and v3 of this) Glibc-2.38 and
it builds OK. So I can bet they are really unused...
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2023-08-14 2:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 17:36 Florian Weimer
2023-08-10 18:04 ` DJ Delorie
2023-08-11 7:20 ` Florian Weimer
2023-08-11 23:14 ` DJ Delorie
2023-08-21 14:01 ` Sam James
2023-08-21 14:45 ` Florian Weimer
2023-08-11 8:54 ` Maxim Kuvyrkov
2023-08-11 9:14 ` Florian Weimer
2023-08-11 14:52 ` Florian Weimer
2023-08-12 6:52 ` Andreas Schwab
2023-08-12 13:23 ` Florian Weimer
2023-08-12 13:33 ` Florian Weimer
2023-08-12 14:50 ` Andreas Schwab
2023-08-14 2:14 ` Xi Ruoyao [this message]
2023-08-14 9:16 ` Florian Weimer
2023-08-15 11:58 ` Adhemerval Zanella Netto
2023-08-14 9:42 Florian Weimer
2023-08-14 20:49 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae91f53030eaeef64b02f67d890eddc503ed4da4.camel@xry111.site \
--to=xry111@xry111.site \
--cc=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).