From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 737413858D35 for ; Thu, 7 Mar 2024 00:05:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 737413858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 737413858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709769928; cv=none; b=S6hvDcZTKPe0zUNudpTaeYMT8p7M8Q+IXbryWc3hY0AT1aCwuXEdFKoZ7wXlnTkHHjKwkKNgjfhbdEmjOrNSrH4QVLM3LnSETdBEQdvm09RfnWgH8eTVaEY7DVj7p8k+qDqFrApxtoJgfC4WCM6JV09PAwgrUyFelwSKSwrabiw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709769928; c=relaxed/simple; bh=aORIZBwPzmlRWN6fwCpCpvhq7aOrBi++BK/0ZiZzmeo=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=tdGL75I2mXqnBZMFdi6Aa9sx0UY0Q0+8aGnSty24/H9LRPM2fIbv7z2rGA5gccCBs11nSp834OIPdNd11ZgUosDanhg7KJBfuZ1uNjZGttMxpPcNbVcS1ulWHMS9t3/ygDoJs4miVlGfn89iI++57MKgKlbf8+EfpL3rnn9N+v8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id 6CDE23090B9D; Thu, 7 Mar 2024 01:05:24 +0100 (CET) Date: Thu, 7 Mar 2024 01:05:24 +0100 From: Mark Wielaard To: Nick Clifton Cc: annobin@sourceware.org Subject: Re: =?utf-8?B?4pigIEJ1aWxkYm8=?= =?utf-8?Q?t?= (Sourceware): annobin - failed test (failure) (master) Message-ID: <20240307000524.GF24213@gnu.wildebeest.org> References: <20240305192202.AB1E43858C98@sourceware.org> <20240305210558.GB24213@gnu.wildebeest.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Nick, On Wed, Mar 06, 2024 at 10:45:53AM +0000, Nick Clifton wrote: > >But in general the debian based builds fail because of the configure > >check for the clang++ include file failing. > > Ah - because it is looking in /usr/include and not `llvm-config --includedir` > > I am not sure how to resolve this. The AC_CHECK_HEADER macro does not allow > for searching in non-standard locations. > > Maybe it would be simpler to just delete this check ? Maybe indeed. I tried and couldn't make it work. AC_CHECK_HEADER seems to ignore things like CFLAGS, so you might have to do it using AC_COMPILE_IFELSE and setting CXXFLAGS based on llvm-config --cflags. But maybe that is too much work. Checking whether llvm-config is installed might be good though. > >And the fedora based builds fail because of a MAYB lto FAIL for the > >debuginfod testcase. > > Right. I have tracked this down to the fact that the new code you > suggested for loading potentially reloc encumbered binary files: > > Dwfl *dwfl = dwfl_begin (&dwfl_callbacks); > Dwfl_Module *module = dwfl_report_elf (dwfl, data->full_filename, data->full_filename, -1, 0, false); > > if (module != NULL) > { > Dwarf_Addr bias; > dwarf = dwfl_module_getdwarf (module, &bias); > } > > Appears to automatically follow debug links, using debuginfod if necessary. > So this means that annocheck no longer reports "I am contacting the > debuginfod server to see if it has the debug info" and so the debuginfod > test fails. :-) ah, yes, sorry about that. libdwfl tries to be really, really helpful. It goes out of its way to find a matching Dwarf. > I will update the test so that it checks to see if the debug information > was silently located. Looks like most things are green now: https://builder.sourceware.org/buildbot/#/builders?tags=annobin Except for debian-i386 and ubuntu-riscv. debian-i386 fails with: clang -fplugin=/home/mark/annobin/clang-plugin/annobin-for-clang.so -D_FORTIFY_SOURCE=2 -O2 -g -grecord-gcc-switches -fPIE -Wall -fsanitize=safe-stack -fstack-protector-strong -fsanitize=cfi-cast-strict -c ./hello.c readelf --wide --notes hello.o > clang-plugin-test.readelf.out make[1]: *** [Makefile:71: check] Error 1 Which seems to be the "running on clang version" thing. And that is because Debian inserts Debian :) $ cat ./clang-plugin/clang-plugin-test.readelf.out Displaying notes found in: .gnu.build.attributes Owner Data size Description GA$3L1244 0x00000008 OPEN Applies to region from 0 to 0x3 (.L.str) GA$running on Debian clang version 14.0.6 0x00000008 OPEN Applies to region from 0 to 0x3 (.L.str) GA$annobin built by clang version 14.0.6 0x00000008 OPEN Applies to region from 0 to 0x3 (.L.str) GA*cf_protection:0x1 0x00000008 OPEN Applies to region from 0 to 0x3 (.L.str) GA*GOW:0x20400 0x00000008 OPEN Applies to region from 0 to 0x3 (.L.str) GA*SpecLoadHarden:0x1 0x00000008 OPEN Applies to region from 0 to 0x3 (.L.str) GA*all 0x00000008 OPEN Applies to region from 0 to 0x3 (.L.str) GA*sanitize_safe_stack:0x1 0x00000008 OPEN Applies to region from 0 to 0x3 (.L.str) GA*sanitize_cfi:0x1 0x00000008 OPEN Applies to region from 0 to 0x3 (.L.str) GA*PIE 0x00000008 OPEN Applies to region from 0 to 0x3 (.L.str) grepping for "running on .*clang version" makes all tests PASS. on riscv-ubuntu things fail during the build: /usr/bin/ld: /usr/lib/llvm-16/bin/../lib/LLVMgold.so: error loading plugin: /usr/lib/llvm-16/bin/../lib/LLVMgold.so: cannot open shared object file: No such file or directory clang: error: linker command failed with exit code 1 (use -v to see invocation) make[1]: *** [Makefile:33: annobin-for-clang.so] Error 1 I think that is because llvm-16-linker-tools isn't installed on the riscv builders. I will try to install those tomorrow. Cheers, Mark