public inbox for archer-commits@sourceware.org
help / color / mirror / Atom feed
From: sergiodj@sourceware.org
To: archer-commits@sourceware.org
Subject: [SCM]  archer-sergiodj-stap: Using string concatenation, calling internal_error instead of error.
Date: Wed, 16 Mar 2011 21:55:00 -0000	[thread overview]
Message-ID: <20110316215512.16875.qmail@sourceware.org> (raw)

The branch, archer-sergiodj-stap has been updated
       via  0d92265d7094189e7d0719f3bec48d6dd7697097 (commit)
      from  d0affce436ede091114a2bd9157d805992bb2482 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email.

- Log -----------------------------------------------------------------
commit 0d92265d7094189e7d0719f3bec48d6dd7697097
Author: Sergio Durigan Junior <sergiodj@redhat.com>
Date:   Wed Mar 16 18:54:42 2011 -0300

    Using string concatenation, calling internal_error instead of error.

-----------------------------------------------------------------------

Summary of changes:
 gdb/stap-probe.c |   24 +++++++++++++-----------
 1 files changed, 13 insertions(+), 11 deletions(-)

First 500 lines of diff:
diff --git a/gdb/stap-probe.c b/gdb/stap-probe.c
index 11368a6..f3c4f33 100644
--- a/gdb/stap-probe.c
+++ b/gdb/stap-probe.c
@@ -98,6 +98,13 @@ struct stap_evaluation_info
 static struct stap_args_info dummy_stap_args_info =
   { 0, NULL, NULL };
 
+/* Evaluation function for probe's argument expressions.  LHS represents
+   the left side of the expression, and PREC is the precedence of the
+   last operator identified before calling the function.  */
+static struct value *
+stap_evaluate_probe_argument_2 (struct stap_evaluation_info *eval_info,
+				struct value *lhs, int prec);
+
 static void
 stap_skip_whitespace_cond (char **s, int inside_paren)
 {
@@ -348,9 +355,8 @@ stap_parse_probe_arguments (struct stap_probe *probe)
 	  if (current_arg >= STAP_MAX_ARGS)
 	    {
 	      complaint (&symfile_complaints,
-			 _("probe `%s' has more arguments than the maximum \
-allowed"),
-			 probe->name);
+			 _("probe `%s' has more arguments than the maximum "
+			   "allowed"), probe->name);
 	      do_cleanups (back_to);
 	      return;
 	    }
@@ -686,9 +692,8 @@ stap_fetch_reg_value (struct stap_evaluation_info *eval_info,
 
   if (displacement && !indirect_p)
     /* We cannot apply displacement to non-indirect register access.  */
-    error (_("Trying to apply displacement without indirecting register \
-on expression `%s'."),
-	   eval_info->saved_expr);
+    error (_("Trying to apply displacement without indirecting register "
+	     "on expression `%s'."), eval_info->saved_expr);
 
   start = s;
   while (isalnum (*s))
@@ -741,7 +746,8 @@ on expression `%s'."),
 	  break;
 
 	default:
-	  error (_("Undefined bitness for probe."));
+	  internal_error (__FILE__, __LINE__,
+			  _("Undefined bitness for probe."));
 	  break;
 	}
 
@@ -758,10 +764,6 @@ on expression `%s'."),
 }
 
 static struct value *
-stap_evaluate_probe_argument_2 (struct stap_evaluation_info *eval_info,
-				struct value *lhs, int prec);
-
-static struct value *
 stap_parse_single_operand (struct stap_evaluation_info *eval_info)
 {
   struct gdbarch *gdbarch = eval_info->gdbarch;


hooks/post-receive
--
Repository for Project Archer.


                 reply	other threads:[~2011-03-16 21:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110316215512.16875.qmail@sourceware.org \
    --to=sergiodj@sourceware.org \
    --cc=archer-commits@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).