From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16918 invoked by alias); 16 Mar 2011 21:55:14 -0000 Mailing-List: contact archer-commits-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: Received: (qmail 16890 invoked by uid 9813); 16 Mar 2011 21:55:12 -0000 Date: Wed, 16 Mar 2011 21:55:00 -0000 Message-ID: <20110316215512.16875.qmail@sourceware.org> From: sergiodj@sourceware.org To: archer-commits@sourceware.org Subject: [SCM] archer-sergiodj-stap: Using string concatenation, calling internal_error instead of error. X-Git-Refname: refs/heads/archer-sergiodj-stap X-Git-Reftype: branch X-Git-Oldrev: d0affce436ede091114a2bd9157d805992bb2482 X-Git-Newrev: 0d92265d7094189e7d0719f3bec48d6dd7697097 X-SW-Source: 2011-q1/txt/msg00212.txt.bz2 List-Id: The branch, archer-sergiodj-stap has been updated via 0d92265d7094189e7d0719f3bec48d6dd7697097 (commit) from d0affce436ede091114a2bd9157d805992bb2482 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email. - Log ----------------------------------------------------------------- commit 0d92265d7094189e7d0719f3bec48d6dd7697097 Author: Sergio Durigan Junior Date: Wed Mar 16 18:54:42 2011 -0300 Using string concatenation, calling internal_error instead of error. ----------------------------------------------------------------------- Summary of changes: gdb/stap-probe.c | 24 +++++++++++++----------- 1 files changed, 13 insertions(+), 11 deletions(-) First 500 lines of diff: diff --git a/gdb/stap-probe.c b/gdb/stap-probe.c index 11368a6..f3c4f33 100644 --- a/gdb/stap-probe.c +++ b/gdb/stap-probe.c @@ -98,6 +98,13 @@ struct stap_evaluation_info static struct stap_args_info dummy_stap_args_info = { 0, NULL, NULL }; +/* Evaluation function for probe's argument expressions. LHS represents + the left side of the expression, and PREC is the precedence of the + last operator identified before calling the function. */ +static struct value * +stap_evaluate_probe_argument_2 (struct stap_evaluation_info *eval_info, + struct value *lhs, int prec); + static void stap_skip_whitespace_cond (char **s, int inside_paren) { @@ -348,9 +355,8 @@ stap_parse_probe_arguments (struct stap_probe *probe) if (current_arg >= STAP_MAX_ARGS) { complaint (&symfile_complaints, - _("probe `%s' has more arguments than the maximum \ -allowed"), - probe->name); + _("probe `%s' has more arguments than the maximum " + "allowed"), probe->name); do_cleanups (back_to); return; } @@ -686,9 +692,8 @@ stap_fetch_reg_value (struct stap_evaluation_info *eval_info, if (displacement && !indirect_p) /* We cannot apply displacement to non-indirect register access. */ - error (_("Trying to apply displacement without indirecting register \ -on expression `%s'."), - eval_info->saved_expr); + error (_("Trying to apply displacement without indirecting register " + "on expression `%s'."), eval_info->saved_expr); start = s; while (isalnum (*s)) @@ -741,7 +746,8 @@ on expression `%s'."), break; default: - error (_("Undefined bitness for probe.")); + internal_error (__FILE__, __LINE__, + _("Undefined bitness for probe.")); break; } @@ -758,10 +764,6 @@ on expression `%s'."), } static struct value * -stap_evaluate_probe_argument_2 (struct stap_evaluation_info *eval_info, - struct value *lhs, int prec); - -static struct value * stap_parse_single_operand (struct stap_evaluation_info *eval_info) { struct gdbarch *gdbarch = eval_info->gdbarch; hooks/post-receive -- Repository for Project Archer.