public inbox for archer-commits@sourceware.org help / color / mirror / Atom feed
From: tromey@sourceware.org To: archer-commits@sourceware.org Subject: [SCM] archer-tromey-dwz-multifile: fix binary search thinko Date: Wed, 06 Jun 2012 19:09:00 -0000 [thread overview] Message-ID: <20120606190900.15214.qmail@sourceware.org> (raw) The branch, archer-tromey-dwz-multifile has been updated via ed604dd3d75f53284ea11af3354ba0a415f4aef8 (commit) via 89cdd03a520f5b43da5cb49133f65a27516a4fb4 (commit) from ee8d9d8801288fb677620e6bfe6e3df888605e81 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email. - Log ----------------------------------------------------------------- commit ed604dd3d75f53284ea11af3354ba0a415f4aef8 Author: Tom Tromey <tromey@redhat.com> Date: Wed Jun 6 12:40:43 2012 -0600 fix binary search thinko commit 89cdd03a520f5b43da5cb49133f65a27516a4fb4 Author: Tom Tromey <tromey@redhat.com> Date: Wed Jun 6 11:47:37 2012 -0600 specially handle DW_FORM_GNU_ref_alt when looking up a type previous we were not dealing properly with the dwz/not-dwz distinction here ----------------------------------------------------------------------- Summary of changes: gdb/dwarf2read.c | 14 +++++++++++--- 1 files changed, 11 insertions(+), 3 deletions(-) First 500 lines of diff: diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index cbb5d20..37ff4c2 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -14081,7 +14081,15 @@ lookup_die_type (struct die_info *die, struct attribute *attr, /* First see if we have it cached. */ - if (is_ref_attr (attr)) + if (attr->form == DW_FORM_GNU_ref_alt) + { + struct dwarf2_per_cu_data *per_cu; + sect_offset offset = dwarf2_get_ref_die_offset (attr); + + per_cu = dwarf2_find_containing_comp_unit (offset, 1, cu->objfile); + this_type = get_die_type_at_offset (offset, per_cu); + } + else if (is_ref_attr (attr)) { sect_offset offset = dwarf2_get_ref_die_offset (attr); @@ -16867,8 +16875,8 @@ dwarf2_find_containing_comp_unit (sect_offset offset, mid_cu = dwarf2_per_objfile->all_comp_units[mid]; cu_off = &mid_cu->offset; - if (mid_cu->is_dwz > offset_in_dwz - || cu_off->sect_off >= offset.sect_off) + if (mid_cu->is_dwz >= offset_in_dwz + && cu_off->sect_off >= offset.sect_off) high = mid; else low = mid + 1; hooks/post-receive -- Repository for Project Archer.
reply other threads:[~2012-06-06 19:09 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120606190900.15214.qmail@sourceware.org \ --to=tromey@sourceware.org \ --cc=archer-commits@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).