public inbox for archer-commits@sourceware.org help / color / mirror / Atom feed
From: tromey@sourceware.org To: archer-commits@sourceware.org Subject: [SCM] archer-tromey-dwz-multifile: maybe rewrite an attribute's form when reading Date: Wed, 06 Jun 2012 21:03:00 -0000 [thread overview] Message-ID: <20120606210304.24532.qmail@sourceware.org> (raw) The branch, archer-tromey-dwz-multifile has been updated via c11f6dbe8028d3ca7b263d54f20164fc2f222d28 (commit) from ed604dd3d75f53284ea11af3354ba0a415f4aef8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email. - Log ----------------------------------------------------------------- commit c11f6dbe8028d3ca7b263d54f20164fc2f222d28 Author: Tom Tromey <tromey@redhat.com> Date: Wed Jun 6 15:01:29 2012 -0600 maybe rewrite an attribute's form when reading if the attribute comes from a .dwz section, and it has a reference form, we rewrite it to DW_FORM_GNU_ref_alt. this lets us continue to invisibly handle abstract die inheritance, and the like, without changes all over the dwarf reader I'm still undecided as to whether this is clean enough to push upstream or whether some deeper fix ought to be done ----------------------------------------------------------------------- Summary of changes: gdb/dwarf2read.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) First 500 lines of diff: diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index 37ff4c2..30123d3 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -11927,6 +11927,10 @@ read_attribute_value (const struct die_reader_specs *reader, bfd_get_filename (abfd)); } + /* Super hack. */ + if (cu->per_cu->is_dwz && is_ref_attr (attr)) + attr->form = DW_FORM_GNU_ref_alt; + /* We have seen instances where the compiler tried to emit a byte size attribute of -1 which ended up being encoded as an unsigned 0xffffffff. Although 0xffffffff is technically a valid size value, hooks/post-receive -- Repository for Project Archer.
reply other threads:[~2012-06-06 21:03 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120606210304.24532.qmail@sourceware.org \ --to=tromey@sourceware.org \ --cc=archer-commits@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).