public inbox for archer-commits@sourceware.org
help / color / mirror / Atom feed
From: tromey@sourceware.org
To: archer-commits@sourceware.org
Subject: [SCM]  archer-tromey-remove-obj_section: initialize the full psymbol
Date: Tue, 18 Dec 2012 15:49:00 -0000	[thread overview]
Message-ID: <20121218154934.7744.qmail@sourceware.org> (raw)

The branch, archer-tromey-remove-obj_section has been updated
       via  f95dc0c957ad8c479e5759c18584a41253881ae6 (commit)
      from  4b16a2aaa6106ff7e3ce65c12e812da1b19ba236 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email.

- Log -----------------------------------------------------------------
commit f95dc0c957ad8c479e5759c18584a41253881ae6
Author: Tom Tromey <tromey@redhat.com>
Date:   Tue Dec 18 08:04:54 2012 -0700

    initialize the full psymbol
    
    this prevents an assertion when the ada_mangled field is uninitialized
    found by Joel

-----------------------------------------------------------------------

Summary of changes:
 gdb/psymtab.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

First 500 lines of diff:
diff --git a/gdb/psymtab.c b/gdb/psymtab.c
index 384a895..9e23932 100644
--- a/gdb/psymtab.c
+++ b/gdb/psymtab.c
@@ -1603,10 +1603,10 @@ add_psymbol_to_bcache (const char *name, int namelength, int copy_name,
 {
   struct partial_symbol psymbol;
 
-  /* We must ensure that the entire 'value' field has been zeroed
-     before assigning to it, because an assignment may not write the
-     entire field.  */
-  memset (&psymbol.ginfo.value, 0, sizeof (psymbol.ginfo.value));
+  /* We must ensure that the entire struct has been zeroed before
+     assigning to it, because an assignment may not touch some of the
+     holes.  */
+  memset (&psymbol, 0, sizeof (psymbol));
 
   /* val and coreaddr are mutually exclusive, one of them *will* be zero.  */
   if (val != 0)


hooks/post-receive
--
Repository for Project Archer.


                 reply	other threads:[~2012-12-18 15:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121218154934.7744.qmail@sourceware.org \
    --to=tromey@sourceware.org \
    --cc=archer-commits@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).