From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23615 invoked by alias); 14 Mar 2013 17:40:42 -0000 Mailing-List: contact archer-commits-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: Received: (qmail 23446 invoked by uid 306); 14 Mar 2013 17:40:40 -0000 Date: Thu, 14 Mar 2013 17:40:00 -0000 Message-ID: <20130314174038.23198.qmail@sourceware.org> From: tromey@sourceware.org To: archer-commits@sourceware.org Subject: [SCM] tromey/constify: reverse-20080717-branchpoint-14229-gd322fc7 X-Git-Refname: refs/heads/tromey/constify X-Git-Reftype: branch X-Git-Oldrev: 0000000000000000000000000000000000000000 X-Git-Newrev: d322fc78389df20e123558cc395ccba57a668a82 X-SW-Source: 2013-q1/txt/msg00257.txt.bz2 List-Id: The branch, tromey/constify has been created at d322fc78389df20e123558cc395ccba57a668a82 (commit) - Log ----------------------------------------------------------------- commit d322fc78389df20e123558cc395ccba57a668a82 Author: Tom Tromey Date: Thu Mar 14 11:39:10 2013 -0600 constify i386-tdep.c commit 10dd1edbd0dd4646f8d2684a9bda42642cd96100 Author: Tom Tromey Date: Thu Mar 14 11:33:47 2013 -0600 constify dummy-frame.c commit 3aa9955df9647dd101c800c9d16ebec91e3ba3cb Author: Tom Tromey Date: Thu Mar 14 11:33:41 2013 -0600 constify gdb_fopen commit 81405a66ab9f3f24fdddaaafa2ce95581f54c0ac Author: Tom Tromey Date: Thu Mar 14 11:31:47 2013 -0600 constify p-valprint.c commit d7d1c4e22de980b8a70f1455e206c473831e12a9 Author: Tom Tromey Date: Thu Mar 14 11:31:29 2013 -0600 constify f-valprint.c commit 911657ba1e649adbff28dc6f93eaa667b84ca18f Author: Tom Tromey Date: Thu Mar 14 11:30:51 2013 -0600 constify mi-cmd-env.c commit 65a007912aabc5836f92390138188c54c8c9a6e4 Author: Tom Tromey Date: Thu Mar 14 11:30:08 2013 -0600 constify i386-nat.c commit acc2513b9a743fa5ff8a7329c41936a6fee1e348 Author: Tom Tromey Date: Thu Mar 14 11:29:43 2013 -0600 constify probe.c commit 7cc60d6f958dee301637ef589ca068345bb49a51 Author: Tom Tromey Date: Thu Mar 14 11:26:50 2013 -0600 constify observer.c commit d54387ca207b8e257bc1db19e2c6583a927bb5ad Author: Tom Tromey Date: Thu Mar 14 11:24:01 2013 -0600 constify xtensa-tdep.c commit 4faa9b48885427385473090104b10d58c6ee0be5 Author: Tom Tromey Date: Thu Mar 14 11:23:26 2013 -0600 constify psymtab.c commit 38ffe5a7dd70af40f0ce9056167ff93d22257212 Author: Tom Tromey Date: Thu Mar 14 11:14:45 2013 -0600 constify stap-probe.c, plus fallout commit 85ffb699895112143ff8eedc08300bfc6bd2459a Author: Tom Tromey Date: Thu Mar 14 11:09:26 2013 -0600 constify cp-valprint.c commit d4a3301e1f539dd2735f90675d409b8d624a2345 Author: Tom Tromey Date: Thu Mar 14 11:09:03 2013 -0600 constify cp-namespace.c commit 62ac4724b68113968cffb9bff2d06b8eca5d57ec Author: Tom Tromey Date: Thu Mar 14 11:06:40 2013 -0600 constify copying.{c,awk} commit e9d61a367bbd8eb2ac8f48cf52dbc184fbbc4bdd Author: Tom Tromey Date: Thu Mar 14 11:02:01 2013 -0600 constify complaints.c commit a64a3458bb875d5a0c8c0adce0383e8eb69f4870 Author: Tom Tromey Date: Thu Mar 14 11:01:46 2013 -0600 constify coff-pe-read.c commit 9d2c66a6f2149051c385df26048c51e9e86a55ab Author: Tom Tromey Date: Thu Mar 14 11:01:23 2013 -0600 constify blockframe.c commit 723dca6e61b895d3564c78727816c12fac6e0002 Author: Tom Tromey Date: Thu Mar 14 11:00:55 2013 -0600 constify auxv.c commit 6c224d566c81954d8e61dbad0e30ec4c6a0a7dff Author: Tom Tromey Date: Thu Mar 14 11:00:11 2013 -0600 constify agent.c commit a73b129f0c0886c0bbba80af1b77073180c7ca94 Author: Tom Tromey Date: Thu Mar 14 10:58:09 2013 -0600 constify ada-typeprint.c commit 093ad191b5a43d963fa7b722b795725fc1fd7ffc Author: Tom Tromey Date: Thu Mar 14 10:57:33 2013 -0600 introduce const-command.h commit 0edf8a7bc8ae41c1ec2d9e49dfd9e0f9c06a76a2 Author: Tom Tromey Date: Thu Mar 14 10:54:26 2013 -0600 constify linespec.c commit 8180c75d00aeab94db5ae03e04b00c28b17c052d Author: Tom Tromey Date: Thu Mar 14 10:53:49 2013 -0600 constify demangle.c commit b95b8ae7b9c3e3eefb632c1fcabd74c5ff247684 Author: Tom Tromey Date: Thu Mar 14 10:52:43 2013 -0600 constify py-evtregistry.c commit 85308c5ea7f64d8166fecb5aaa49c75b3bbc63df Author: Tom Tromey Date: Thu Mar 14 10:52:14 2013 -0600 constify python.c commit 35b5b8afe74bdfcfcabfae44c050c2fa20bed2f7 Author: Tom Tromey Date: Thu Mar 14 10:48:50 2013 -0600 constify auto-load.c commit 7399f505f0722451ee2160d54ecef20e92dfe5e1 Author: Tom Tromey Date: Thu Mar 14 10:44:35 2013 -0600 constify do_set_command, do_show_command, and cmd_show_list commit 44cdd6a075d08d9751cfa59bddc0a31857cf1045 Author: Tom Tromey Date: Thu Mar 14 10:41:24 2013 -0600 constify parse_and_eval_long commit 894ac396338beb202110c742ea78536af1a4d4d0 Author: Tom Tromey Date: Thu Mar 14 10:37:34 2013 -0600 partial constification of parse_escape commit d434ede01c282577e33e1bec27c509c720a4ae0c Author: Tom Tromey Date: Thu Mar 14 10:30:33 2013 -0600 update cp-abi.c commit 7bd72424163113c3aac4b4ba6b88319bbd4b4caf Author: Tom Tromey Date: Tue Mar 12 10:00:32 2013 -0600 constify struct block commit e6bde081e6eca86ca88215f9dbb8a15d5ad819d2 Author: Tom Tromey Date: Tue Mar 12 09:51:37 2013 -0600 constify struct block in some places commit 24f3f952b18c357afe63ac97455b786933a9f233 Author: Tom Tromey Date: Sun Nov 18 19:34:55 2012 -0700 jit.c commit e492cd76e9baa8f8df6f9d6242f8561ba1dbf035 Author: Tom Tromey Date: Sun Nov 18 19:34:24 2012 -0700 gdb_bfd commit 20589f9b24344e576a86b08cc6e5ee1c573b643e Author: Tom Tromey Date: Sun Nov 18 19:32:28 2012 -0700 dwarf2read commit 3b31016ca3018981926ff0d4e810a83e3e3d1ed0 Author: Tom Tromey Date: Sun Nov 18 19:24:22 2012 -0700 basic change, use function type more commit 644f70060bede7c489d2169198ffb66183b0849d Author: Tom Tromey Date: Tue Mar 12 09:58:47 2013 -0600 add README.archer commit ae7f3bbb9fed17d911cd402f26077b9caca2a03d Author: qiyao Date: Thu Mar 14 13:33:58 2013 +0000 gdb/testsuite/ * config/monitor.exp (gdb_target_cmd): Remove semicolon after 'return'. (gdb_target_monitor, gdb_load): Likewise. * config/sid.exp (gdb_load): Likewise. * config/slite.exp (gdb_load): Likewise. * config/vx.exp (gdb_start, spawn_vxgdb): Likewise. * gdb.ada/arrayidx.exp, gdb.ada/null_array.exp: Likewise. * gdb.arch/mips-octeon-bbit.exp (single_step): Likewise. (single_step_until): Likewise. * gdb.arch/powerpc-d128-regs.exp: Likewise. * gdb.arch/system-gcore.exp: Likewise. * gdb.base/bigcore.exp (extract_heap): Likewise. * gdb.base/break-on-linker-gcd-function.exp: Likewise. * gdb.base/call-ar-st.exp: Likewise. * gdb.base/call-rt-st.exp: Likewise. * gdb.base/call-sc.exp, gdb.base/call-strs.exp: Likewise. * gdb.base/callfuncs.exp, gdb.base/completion.exp: Likewise. * gdb.base/condbreak.exp, gdb.base/constvars.exp: Likewise. * gdb.base/corefile.exp: Likewise. * gdb.base/dbx.exp (gdb_file_cmd): Likewise. * gdb.base/exprs.exp, gdb.base/fileio.exp: Likewise. * gdb.base/fixsection.exp: Likewise. * gdb.base/funcargs.exp: Likewise. * gdb.base/gcore-buffer-overflow.exp: Likewise. * gdb.base/gcore-relro.exp: Likewise. * gdb.base/gcore.exp, gdb.base/gdb11530.exp: Likewise. * gdb.base/gdb11531.exp, gdb.base/gnu-ifunc.exp: Likewise. * gdb.base/info-os.exp, gdb.base/info-proc.exp: Likewise. * gdb.base/interp.exp, gdb.base/langs.exp:: Likewise. * gdb.base/list.exp: Likewise. (set_listsize): Likewise. * gdb.base/logical.exp, gdb.base/mips_pro.exp: Likewise. * gdb.base/miscexprs.exp, gdb.base/nodebug.exp: Likewise. * gdb.base/opaque.exp, gdb.base/pointers.exp: Likewise. * gdb.base/psymtab.exp, gdb.base/ptype.exp: Likewise. * gdb.base/relational.exp, gdb.base/scope.exp: Likewise. * gdb.base/setvar.exp: Likewise. (test_set): Likewise. * gdb.base/signals.exp, gdb.base/sizeof.exp: Likewise. * gdb.base/solib-overlap.exp: Likewise. * gdb.base/store.exp, gdb.base/structs.exp: Likewise. * gdb.base/structs2.exp, gdb.base/volatile.exp: Likewise. * gdb.base/watchpoint.exp (initialize): Likewise. (test_simple_watchpoint): Likewise. (test_disabling_watchpoints): Likewise. (test_watchpoint_triggered_in_syscall): Likewise. * gdb.base/whatis.exp, gdb.cp/ambiguous.exp: Likewise. * gdb.cp/casts.exp, gdb.cp/ctti.exp: Likewise. * gdb.cp/namespace.exp, gdb.cp/nsdecl.exp: Likewise. * gdb.cp/psmang.exp, gdb.dwarf2/dw2-ranges.exp: Likewise. * gdb.hp/gdb.aCC/optimize.exp: Likewise. * gdb.hp/gdb.aCC/watch-cmd.exp: Likewise. * gdb.hp/gdb.base-hp/callfwmall.exp: Likewise. * gdb.hp/gdb.base-hp/pxdb.exp: Likewise. * gdb.hp/gdb.compat/xdb1.exp: Likewise. * gdb.hp/gdb.compat/xdb2.exp: Likewise. * gdb.hp/gdb.compat/xdb3.exp: Likewise. * gdb.hp/gdb.defects/bs14602.exp: Likewise. * gdb.hp/gdb.defects/solib-d.exp: Likewise. * gdb.mi/gdb792.exp: Likewise. * gdb.mi/mi-inheritance-syntax-error.exp: Likewise. * gdb.mi/mi-logging.exp, gdb.mi/mi-var-cp.exp : Likewise. * gdb.mi/mi-var-rtti.exp, gdb.python/py-type.exp: Likewise. * gdb.threads/gcore-thread.exp: Likewise. (load_core): Likewise. * gdb.threads/pthreads.exp (all_threads_running): Likewise. (test_startup, check_control_c): Likewise. * gdb.threads/sigstep-threads.exp: Likewise. * gdb.threads/thread_check.exp: Likewise. * gdb.trace/backtrace.exp, gdb.trace/change-loc.exp: Likewise. * gdb.trace/circ.exp (run_trace_experiment): Likewise. (set_a_tracepoint, trace_buffer_normal): Likewise. (gdb_trace_circular_tests): Likewise. * gdb.trace/collection.exp: Likewise. * gdb.trace/disconnected-tracing.exp: Likewise. * gdb.trace/infotrace.exp: Likewise. * gdb.trace/mi-traceframe-changed.exp: Likewise. * gdb.trace/mi-tracepoint-changed.exp: Likewise. * gdb.trace/mi-tsv-changed.exp (test_create_delete_modify_tsv): Likewise. * gdb.trace/packetlen.exp, gdb.trace/passc-dyn.exp: Likewise. * gdb.trace/pending.exp, gdb.trace/report.exp: Likewise. * gdb.trace/stap-trace.exp: Likewise. * gdb.trace/status-stop.exp,gdb.trace/strace.exp: Likewise. * gdb.trace/tfind.exp, gdb.trace/trace-break.exp: Likewise. * gdb.trace/trace-buffer-size.exp: Likewise. * gdb.trace/tspeed.exp, gdb.trace/tsv.exp: Likewise. * gdb.trace/unavailable.exp: Likewise. * gdb.trace/while-dyn.exp: Likewise. * lib/fortran.exp (set_lang_fortran): Likewise. * lib/gdb.exp (default_gdb_version, gdb_start_cmd): Likewise. (gdb_breakpoint, gdb_reinitialize_dir): Likewise. (default_gdb_start, get_compiler_info): Likewise. (gdb_compile, gdb_compile_objc, gdb_reload, gdb_init): Likewise. (get_debug_format, setup_xfail_format): Likewise. (rerun_to_main, gdb_skip_float_test): Likewise. (build_id_debug_filename_get, get_remotetimeout): Likewise. * lib/java.exp (set_lang_java): Likewise. * lib/mi-support.exp (default_mi_gdb_start): Likewise. (mi_gdb_reinitialize_dir, mi_gdb_target_cmd): Likewise. (mi_gdb_file_cmd, mi_gdb_test): Likewise. (mi_run_cmd_full, mi_expect_interrupt): Likewise. * lib/objc.exp (set_lang_objc): Likewise. * lib/pascal.exp (set_lang_pascal): Likewise. * lib/prompt.exp (default_prompt_gdb_start): Likewise. * lib/trace-support.exp (gdb_trace_setactions, gdb_tfind_test): Likewise. (gdb_readexpr, gdb_gettpnum, gdb_find_recursion_test_baseline): Likewise. commit bcf5c9e38ad8f5f6b9756bba70d1455528efc80a Author: sergiodj Date: Thu Mar 14 11:40:08 2013 +0000 2013-03-14 Sergio Durigan Junior * tracepoint.c (cmd_qtv): Initialize `val' with zero, silencing compiler warning. commit 50825096ebd1289bf855f473cc751e0c77439df6 Author: sergiodj Date: Thu Mar 14 11:13:29 2013 +0000 From: Sergio Durigan Junior Subject: [PATCH] Fix for PR c++/15203 and PR c++/15210 Date: Sat, 09 Mar 2013 02:50:49 -0300 (5 days, 4 hours, 57 minutes ago) Message-ID: Hi, This bug was reported internally at our Bugzilla, along with a proposed fix. After talking to Keith about it, he investigated and came up with another patch needed to really fix the issue on CVS HEAD. The first part of the fix is the patch to cp-namespace.c. It handles the case when we are accessing a static variable inside a function (inside a class) by the full linespec (is it right, Keith?). E.g.: class foo { public: int bar() { static int var = 0; } }; And then, printing the value of `var': (gdb) print 'foo::bar()::var' GDB would fall in an internal_error: gdb/cp-namespace.c:816: internal-error: cp_lookup_nested_symbol called on a non-aggregate type. This is because `cp_lookup_nested_symbol' is not handling the case when TYPE_CODE is either _FUNC or _METHOD. This patch fixes it by returning NULL in this case. The second part of the fix is the patch to elfread.c. It is needed because the BSF_GNU_UNIQUE flag was added to some symbols in . Because of that, (still) the command: (gdb) print 'foo::bar()::var' where `var' is a static variable returns: "No symbol "foo::bar()::var" in current context." So with the second patch applied the command finally DTRT: (gdb) print 'foo::bar()::var' $1 = 0 This may not be the ideal solution, according to Keith it would be good to implement productions on c-exp.y in order to recognize CLASS::FUNCTION::VARIABLE, but it is a solution which works with what we have today. I regtested it in Fedora 17 x86_64 with -m64 and -m32, including gdbserver, without regressions. gdb/: 2013-03-14 Keith Seitz Alan Matsuoka PR c++/15203 PR c++/15210 * cp-namespace.c (cp_lookup_nested_symbol): Handle TYPE_CODE_FUNC and TYPE_CODE_METHOD. * elfread.c (elf_symtab_read): Handle BSF_GNU_UNIQUE for certain symbols. gdb/testsuite/: 2013-03-14 Sergio Durigan Junior PR c++/15203 PR c++/15210 * gdb.cp/m-static.cc (keepalive_int): New function. (gnu_obj_1::method): New variable `sintvar', call `keepalive_int'. * gdb.cp/m-static.exp: New test for `sintvar'. commit f9751e10cd9fab917e8963056811ddd012f82563 Author: qiyao Date: Thu Mar 14 09:12:20 2013 +0000 gdb/testsuite/ * gdb.trace/tstatus.exp (run_trace_experiment): Save the output of 'tstatus' into tstatus_output. (top level): Save the trace data to tfile. Read trace file in tfile target. Check the trace status. commit 1b0665319b05e99eb1f5bd4a5e4bbd8f0bf40c88 Author: qiyao Date: Thu Mar 14 09:08:55 2013 +0000 gdb/ * tracepoint.c (tfile_write_status): Write 'stop_desc' of trace status to tfile if trace is stopped by command 'tstop'. commit 1d53f417761af933617b907b5c624034651e1812 Author: qiyao Date: Thu Mar 14 09:06:40 2013 +0000 gdb/ * tracepoint.c (tfile_write_status): Write trace notes and user name into tfile if they are not NULL. commit 16617b5f89535364fa7b12f5578d669cb68fc9a9 Author: qiyao Date: Thu Mar 14 09:02:26 2013 +0000 gdb/ 2013-03-14 Hui Zhu Yao Qi * Makefile.in (REMOTE_OBS): Add ctf.o. (SFILES): Add ctf.c. (HFILES_NO_SRCDIR): Add ctf.h. * ctf.c, ctf.h: New files. * tracepoint.c: Include 'ctf.h'. (collect_pseudocommand): Remove static. (trace_save_command): Parse option "-ctf". Produce different trace file writers per option. Adjust output message. (trace_save_tfile, trace_save_ctf): New. * tracepoint.h (trace_save_tfile, trace_save_ctf): Declare. * mi/mi-main.c: Include 'ctf.h'. (mi_cmd_trace_save): Handle option '-ctf'. Call either trace_save_tfile or trace_save_ctf. * NEWS: Mention these changes. gdb/doc/ 2013-03-14 Hui Zhu Yao Qi * gdb.texinfo (Trace Files): Add "tsave -ctf". commit d048c126aeb0039fea034c7ff0521d2d8f5cc72b Author: qiyao Date: Thu Mar 14 08:50:52 2013 +0000 gdb/ * tracepoint.c (trace_file_writer_xfree): New. (struct tfile_writer_data): New. (tfile_dtor, tfile_can_target_save, tfile_start): New. (tfile_write_header, tfile_write_regblock_type): New. (tfile_write_status, tfile_write_uploaded_tsv): New. (tfile_write_uploaded_tp, tfile_write_definition_end): New. (tfile_write_raw_data, (tfile_end): New. (tfile_write_ops): New global variable. (TRACE_WRITE_R_BLOCK): New macro. (TRACE_WRITE_M_BLOCK_HEADER): New macro. (TRACE_WRITE_M_BLOCK_MEMORY): New macro. (TRACE_WRITE_V_BLOCK): New macro. (trace_save): Add extra one parameter WRITER. Make it static. Use WRITER to writer trace. (tfile_trace_file_writer_new): New. (trace_save_command): Caller update. (trace_save_tfile): Write trace data in TFILE format. * tracepoint.h (struct trace_frame_write_ops): New. (struct trace_file_write_ops): New. (struct trace_file_writer): New. (trace_save): Remove its declaration. (trace_save_tfile): Declare it. * mi/mi-main.c (mi_cmd_trace_save): Call trace_save_tfile instead of trace_save. commit 7fc923bb52d279963790ffe74be3be6dc45d1190 Author: gdbadmin Date: Thu Mar 14 00:00:34 2013 +0000 *** empty log message *** commit 4770af5e2f3c3042ecaa1be33f2864d0c64749bb Author: Alan Modra Date: Wed Mar 13 23:00:04 2013 +0000 daily update commit 6b25dae901ddedb3f330803542d3eac73cdcae4b Author: Pedro Alves Date: Wed Mar 13 18:50:15 2013 +0000 Make hppa-hpux-nat.c:hppa_hpux_save_state_offset static. Dave reports: > There is one small (...) issue that needs fixing: > > gcc -g -O2 -I. -I../../src/gdb -I../../src/gdb/common -I../../src/gdb/config -DLOCALEDIR="\"/opt/gnu64/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber -I../../src/gdb/../libdecnumber -I../../src/gdb/gnulib/import -Ibuild-gnulib/import -DTUI=1 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -Werror -c -o hppa-hpux-nat.o -MT hppa-hpux-nat.o -MMD -MP -MF .deps/hppa-hpux-nat.Tpo ../../src/gdb/hppa-hpux-nat.c > ../../src/gdb/hppa-hpux-nat.c:45:1: error: no previous prototype for 'hppa_hpux_save_state_offset' [-Werror=missing-prototypes] > cc1: all warnings being treated as errors > > Believe the function should be static. gdb/ 2013-03-13 Pedro Alves * hppa-hpux-nat.c (hppa_hpux_save_state_offset): Make static. commit d28b4a8d577ec45eea6136711e380f3c9dff0b58 Author: Pedro Alves Date: Wed Mar 13 18:38:10 2013 +0000 Fix completer.c FIXME, and invalid pointer to pointer conversion. As mentioned in the previous patch, I grepped for "\*\*) &" and found one hit in completer.c. I was about to post a patch that simply made current_demangling_style_string const, and cast away constness at the xfree site. However, looking deeper, it seem to be there's a lot of dead code in the file. First, all external callers of set_demangling_style are found in the stabs reader, commented out for over 12 years: http://sourceware.org/ml/gdb-patches/2000-12/msg00214.html I don't think it's likely we'll ever make the older mangling schemes work for stabs. If we do, we can rediscuss the approach then. Then, set_demangling_command has special handling for unknown demangling styles, but "set demangle-style" is an enum command, and with those, the user can only specify a known enumeration value, by design: (gdb) set demangle-style gangnam-style Undefined item: "gangnam-style". This patch removes all that dead code, then makes current_demangling_style_string point to an element of demangling_style_names, as the FIXME suggests, and then makes current_demangling_style_string, removing the need for the 'const char **' cast. gdb/ 2013-03-13 Pedro Alves * dbxread.c (read_ofile_symtab, process_one_symbol): Remove commented out code. * demangle.c (current_demangling_style_string): Make it const. (set_demangling_command): Assert the demangling style is known. Remove all handling of unknown styles. Set 'current_demangling_style_string' to an element of the demangling_style_names array. (set_demangling_style): Delete. (_initialize_demangler): Set current_demangling_style_string to the element of the demangling_style_names array that corresponds to the default demangling style. Remove FIXME note. Don't call set_demangling_style. * gdb-demangle.h (set_demangling_style): Remove declaration. commit f8dd26f1a5f57c45274f13ee6950ade0382e7155 Author: Joel Brobecker Date: Wed Mar 13 18:37:54 2013 +0000 Extraneous NULL in linux_target_ops when HAVE_LINUX_BTRACE not defined This fixes the followin error when HAVE_LINUX_BTRACE is not defined: linux-low.c:5943: error: excess elements in struct initializer linux-low.c:5943: error: (near initialization for 'linux_target_ops') gdb/gdbserver/ChangeLog: * linux-low.c (linux_target_ops) [!HAVE_LINUX_BTRACE]: Remove extraneous NULL element. commit 2793605d9bb13dbbb3d73b4a2bc4497aaa5bb182 Author: Pedro Alves Date: Wed Mar 13 18:34:52 2013 +0000 Constify strings in tracepoint.c, lookup_cmd and the completers. This is sort of a continuation of Keith's parse_exp_1 constification patch. It started out by undoing these bits: @@ -754,9 +754,12 @@ validate_actionline (char **line, struct tmp_p = p; for (loc = t->base.loc; loc; loc = loc->next) { - p = tmp_p; - exp = parse_exp_1 (&p, loc->address, + const char *q; + + q = tmp_p; + exp = parse_exp_1 (&q, loc->address, block_for_pc (loc->address), 1); + p = (char *) q; and progressively making more things const upwards, fixing fallout, rinse repeat, until GDB built again (--enable-targets=all). That ended up constifying lookup_cmd/add_cmd and (lots of) friends, and the completers. I didn't try to constify the command hooks themselves, because I know upfront there are commands that write to the command string argument, and I think I managed to stop at a nice non-hacky split point already. I think the only non-really-super-obvious changes are tracepoint.c:validate_actionline, and tracepoint.c:trace_dump_actions. The rest is just mostly about 'char *' => 'const char *', 'char **'=> 'const char **', and the occasional (e.g., deprecated_cmd_warning) case of 'char **'=> 'const char *', where/when I noticed that nothing actually cares about the pointer to pointer output. Tested on x86_64 Fedora 17, native and gdbserver. gdb/ 2013-03-13 Pedro Alves * ada-lang.c (struct add_partial_datum) : Make fields const. (ada_make_symbol_completion_list): Make "text0" parameter const. * ax-gdb.c (agent_eval_command_one): Make "exp" parameter const. * breakpoint.c (condition_completer): Make "text" and "word" parameters const. Adjust. (check_tracepoint_command): Adjust to validate_actionline prototype change. (catch_syscall_completer): Make "text" and "word" parameters const. * cli/cli-cmds.c (show_user): Make "comname" local const. (valid_command_p): Make "command" parameter const. (alias_command): Make "alias_prefix" and "command_prefix" locals const. * cli/cli-decode.c (add_cmd): Make "name" parameter const. (add_alias_cmd): Make "name" and "oldname" parameters const. Adjust. No longer make copy of OLDNAME. (add_prefix_cmd, add_abbrev_prefix_cmd, add_set_or_show_cmd) (add_setshow_cmd_full, add_setshow_enum_cmd) (add_setshow_auto_boolean_cmd, add_setshow_boolean_cmd) (add_setshow_filename_cmd, add_setshow_string_cmd) (add_setshow_string_noescape_cmd) (add_setshow_optional_filename_cmd, add_setshow_integer_cmd) (add_setshow_uinteger_cmd, add_setshow_zinteger_cmd) (add_setshow_zuinteger_unlimited_cmd, add_setshow_zuinteger_cmd) (delete_cmd, add_info, add_info_alias, add_com, add_com_alias): Make "name" parameter const. (help_cmd): Rename "command" parameter to "arg". New const local "command". (find_cmd): Make "command" parameter const. (lookup_cmd_1): Make "text" parameter pointer to const. Adjust to deprecated_cmd_warning prototype change. (undef_cmd_error): Make "cmdtype" parameter const. (lookup_cmd): Make "line" parameter const. (deprecated_cmd_warning): Change type of "text" parameter to pointer to const char, from pointer to pointer to char. Adjust. (lookup_cmd_composition): Make "text" parameter const. (complete_on_cmdlist, complete_on_enum): Make "text" and "word" parameters const. * cli/cli-decode.h (struct cmd_list_element) : Make field const. * cli/cli-script.c (validate_comname): Make "tem" local const. (define_command): New const local "tem_c". Use it in calls to lookup_cmd. (document_command): Make "tem" and "comfull" locals const. (show_user_1): Make "prefix" and "name" parameters const. * cli-script.h (show_user_1): Make "prefix" and "name" parameters const. * command.h (add_cmd, add_alias_cmd, add_prefix_cmd) (add_abbrev_prefix_cmd, completer_ftype, lookup_cmd, lookup_cmd_1) (deprecated_cmd_warning, lookup_cmd_composition, add_com) (add_com_alias, add_info, add_info_alias, complete_on_cmdlist) (complete_on_enum, add_setshow_enum_cmd) (add_setshow_auto_boolean_cmd, add_setshow_boolean_cmd) (add_setshow_filename_cmd, add_setshow_string_cmd) (add_setshow_string_noescape_cmd) (add_setshow_optional_filename_cmd, add_setshow_integer_cmd) (add_setshow_uinteger_cmd, add_setshow_zinteger_cmd) (add_setshow_zuinteger_cmd, add_setshow_zuinteger_unlimited_cmd): Change prototypes, constifying strings. * completer.c (noop_completer, filename_completer): Make "text" and "prefix" parameters const. (location_completer, expression_completer) (complete_line_internal): Make "text" and "prefix" parameters const and adjust. (command_completer, signal_completer): Make "text" and "prefix" parameters const. * completer.h (noop_completer, filename_completer) (expression_completer, location_completer, command_completer) (signal_completer): Change prototypes. * corefile.c (complete_set_gnutarget): Make "text" and "word" parameters const. * cp-abi.c (cp_abi_completer): Likewise. * expression.h (parse_expression_for_completion): Change prototype. * f-lang.c (f_make_symbol_completion_list): Make "text" and "word" parameters const. * infcmd.c (_initialize_infcmd): Make "cmd_name" local const. * infrun.c (handle_completer): Make "text" and "word" parameters const. * interps.c (interpreter_completer): Make "text" and "word" parameters const. * language.h (struct language_defn) : Make "text" and "word" parameters const. * parse.c (parse_exp_1): Move const hack to parse_exp_in_context. (parse_exp_in_context): Rename to ... (parse_exp_in_context_1): ... this. (parse_exp_in_context): Reimplement, with const hack from parse_exp_1. (parse_expression_for_completion): Make "string" parameter const. * printcmd.c (decode_format): Make "string_ptr" parameter pointer to pointer to const char. Adjust. (print_command_1): Make "exp" parameter const. (output_command): Rename to ... (output_command_const): ... this. Make "exp" parameter const. (output_command): Reimplement. (x_command): Adjust. (display_command): Rename "exp" parameter to "arg". New "exp" local, const version of "arg". * python/py-auto-load.c (gdbpy_initialize_auto_load): Make "cmd_name" local const. * python/py-cmd.c (cmdpy_destroyer): Cast const away in xfree call. (cmdpy_completer): Make "text" and "word" parameters const. (gdbpy_parse_command_name): Make "prefix_text2" local const. * python/py-param.c (add_setshow_generic): Make "tmp_name" local const. * remote.c (_initialize_remote): Make "cmd_name" local const. * symtab.c (language_search_unquoted_string): Make "text" and "p" parameters const. Adjust. (completion_list_add_fields): Make "sym_text", "text" and "word" parameters const. (struct add_name_data) : Make fields const. (default_make_symbol_completion_list_break_on): Make "text" and "word" parameters const. Adjust locals. (default_make_symbol_completion_list) (make_symbol_completion_list, make_symbol_completion_type) (make_symbol_completion_list_fn): Make "text" and "word" parameters const. (make_file_symbol_completion_list): Make "text", "word" and "srcfile" parameters const. Adjust locals. (add_filename_to_list): Make "text" and "word" parameters const. (struct add_partial_filename_data) : Make fields const. (make_source_files_completion_list): Make "text" and "word" parameters const. * symtab.h (default_make_symbol_completion_list_break_on) (default_make_symbol_completion_list, make_symbol_completion_list) (make_symbol_completion_type enum type_code) (make_symbol_completion_list_fn make_file_symbol_completion_list) (make_source_files_completion_list): Change prototype. * top.c (execute_command): Adjust to pass pointer to pointer to const char to lookup_cmd, and to deprecated_cmd_warning prototype change. (set_verbose): Make "cmdname" local const. * tracepoint.c (decode_agent_options): Make "exp" parameter const, and adjust. (validate_actionline): Make "line" parameter a pointer to const char, and adjust. (encode_actions_1): Make "action_exp" local const, and adjust. (encode_actions): Adjust. (replace_comma): Delete. (trace_dump_actions): Make "action_exp" and "next_comma" locals const, and adjust. Don't frob the action string while splitting it at commas. Instead, make a copy of each split substring in turn. (trace_dump_command): Adjust to validate_actionline prototype change. * tracepoint.h (decode_agent_options, decode_agent_options) (encode_actions, validate_actionline): Change prototypes. * valprint.h (output_command): Delete declaration. (output_command_const): Declare. * value.c (function_destroyer): Cast const away in xfree call. commit 6f094a7631ce53c88c1454f5dac26473ed0312d6 Author: Keith Seitz Date: Wed Mar 13 17:55:50 2013 +0000 * gdb.texinfo (Maintenance Commands): Add missing ')' for "maint agent" reference to Dynamic printf. commit 243a8189577dfee5d11924750bfe0a2024963e88 Author: Pedro Alves Date: Wed Mar 13 16:45:06 2013 +0000 More invalid pointer to pointer conversions. As a follow up to: http://sourceware.org/ml/gdb-patches/2013-03/msg00449.html In a nutshell, casts between 'char **' <-> 'unsigned char **' and 'char **' <-> 'const char **' are invalid. I grepped for "\*\*) &" and found these. There's another one in demangle.c, but I've split fixing that one to a separate patch. I think the ada_decode_symbol change is perhaps the one that could be surprising. The function's description has this comment, which makes things much clearer: The GSYMBOL parameter is "mutable" in the C++ sense: logically const, but nevertheless modified to a semantically equivalent form when a decoded name is cached in it. */ const char * ada_decode_symbol (const struct general_symbol_info *gsymbol) With that out of the way, I think the patch ends up being pretty obvious. Tested on x86_64 Fedora 17. gdb/ 2013-03-13 Pedro Alves * ada-lang.c (ada_decode_symbol): Cast away constness of GSYMBOL rather than casting 'const char * const *' to 'const char **'. * ada-lex.l (processInt): Make "trailer" local const. Remove 'const char **' cast. * arm-linux-tdep.c (arm_stap_parse_special_token): Add 'char *' locals, and use those as strtol output pointer, instead than doing invalid casts to from 'const char **' to 'char **'. (_initialize_demangle): Remove cast. * i386-tdep.c (i386_stap_parse_special_token): : Add 'char *' locals, and use those as strtol output pointer, instead than doing invalid casts to from 'const char **' to 'char **'. * solib-dsbt.c (dsbt_get_initial_loadmaps): Remove 'gdb_byte**' casts. * stap-probe.c (stap_parse_register_operand) (stap_parse_single_operand): Likewise. commit 98486eff86243307ae5c2c5beb6494edd0bd2219 Author: qiyao Date: Wed Mar 13 03:40:26 2013 +0000 * tracepoint.c (tfile_get_trace_state_variable_value): Look for the last matched 'V' blcok in trace frame. gdb/gdbserver: * tracepoint.c (traceframe_read_tsv): Look for the last matched 'V' block in trace frame. gdb/testsuite: * gdb.trace/tsv.exp (check_tsv): New. (top level): Save a tfile on current trace session. Call check_tsv on live target. Load the tfile with target tfile and call check_tsv again. commit dfeab3ef16ca6d5c2db720b26030855f172dd240 Author: qiyao Date: Wed Mar 13 03:25:12 2013 +0000 gdb/testsuite/ 2013-03-13 Yao Qi * gdb.trace/tsv.exp: Remove code unrelated to testing TSV. Replace some "gdb_test" with "gdb_test_no_output". commit 0e28d5962edd389b9a312d27bb2e4860e83873db Author: gdbadmin Date: Wed Mar 13 00:00:03 2013 +0000 *** empty log message *** commit fe278cba1c38983618d12c7ef97040ba24043ba6 Author: Alan Modra Date: Tue Mar 12 23:00:04 2013 +0000 daily update commit 763eb81a7df31394239f1e8e2f020beff9089cff Author: Joel Brobecker Date: Tue Mar 12 22:36:26 2013 +0000 Update NEWS file following GDB 7.6 branch creation. gdb/ChangeLog: * NEWS: Create a new section for the next release branch. Rename the section of the current branch, now that it has been cut. commit 3b7c7af67b57482c437c4e3105119f380624547b Author: gdbadmin Date: Tue Mar 12 22:23:41 2013 +0000 Record GDB 7.6 branch creation. Bump version number to 7.6.50.20130312-cvs. commit ebea35a6c9fcbe39e6bc71925fbe4c5dc4fa2175 Author: Sandra Loosemore Date: Tue Mar 12 19:18:57 2013 +0000 2013-03-12 Sebastian Huber include/ * opcode/nios2.h: Edit comment. gas/ * config/tc-nios2.c (nios2_consume_arg): Delete 'k' case. Add 'o' case. Add default BAD_CASE to switch. gas/testsuite/ * gas/nios2/break.d: Check instruction values. commit e1be38d26431f8f00bbbe782b5c3b9f2f00eca10 Author: Keith Seitz Date: Tue Mar 12 18:50:37 2013 +0000 * mi/mi-cmds.h (mi_execute_command): Make "cmd" const. * mi/mi-interp.c (mi_interpreter_exec): Make "command" const. Remove temporary copy of input string. (mi_execute_command_wrapper): Make "cmd" const. * mi/mi-main.c (mi_execute_command): Make "string_ptr" const. * mi/mi-parse.c (mi_parse_argv): Make "args" const. Use const strings. (mi_parse): Make "cmd" const. Use const strings. * mi/mi-parse.h (mi_parse): Make "cmd" const. commit 2ed1c04f8d7c53405eead13f9f11c7478c3ee411 Author: Keith Seitz Date: Tue Mar 12 17:39:39 2013 +0000 * ada-lang.c (ada_read_renaming_var_value): Pass const pointer to expression string to parse_exp_1. (create_excep_cond_exprs): Likewise. * ax-gdb.c (agent_eval_command_one): Likewise. (maint_agent_printf_command): Likewise. Constify much of the string handling/parsing. * breakpoint.c (set_breakpoint_condition): Pass const pointer to expression string to parse_exp_1. (update_watchpoint): Likewise. (parse_cmd_to_aexpr): Constify string handling. Pass const pointer to parse_exp_1. (init_breakpoint_sal): Pass const pointer to parse_exp_1. (find_condition_and_thread): Likewise. Make TOK const. (watch_command_1): Make "arg" const. Constify string handling. Copy the expression string instead of changing the input string. (update_breakpoint_location): Pass const pointer to parse_exp_1. * eval.c (parse_and_eval_address): Make "exp" const. (parse_to_comma_and_eval): Make "expp" const. (parse_and_eval): Make "exp" const. * expression.h (parse_expression): Make argument const. (parse_exp_1): Make first argument const. * findcmd.c (parse_find_args): Treat "args" as const. * linespec.c (parse_linespec): Pass const pointer to linespec_expression_to_pc. (linespec_expression_to_pc): Make "exp_ptr" const. * parse.c (parse_exp_1): Make "stringptr" const. Make a copy of the expression to pass to parse_exp_in_context until this whole interface can be constified. (parse_expression): Make "string" const. * printcmd.c (ui_printf): Treat "arg" as const. Handle const strings. * tracepoint.c (validate_actionline): Pass const pointer to all calls to parse_exp_1. (encode_actions_1): Likewise. * value.h (parse_to_comma_and_eval): Make argument const. (parse_and_eval_address): Likewise. (parse_and_eval): Likewise. * varobj.c (varobj_create): Pass const pointer to parse_exp_1. (varobj_set_value): Likewise. * cli/cli-cmds.c (disassemble_command): Treat "arg" as const and constify string handling. Pass const pointers to parse_and_eval_address and parse_to_comman_and_eval. * cli/cli-utils.c (skip_to_space): Rename to ... (skip_to_space_const): ... this. Handle const strings. * cli/cli-utils.h (skip_to_space): Turn into macro which invokes skip_to_space_const. (skip_to_space_const): Declare. * common/format.c (parse_format_string): Make "arg" const. Handle const strings. * common/format.h (parse_format_string): Make "arg" const. * gdbserver/ax.c (ax_printf): Make "format" const. * python/python.c (gdbpy_parse_and_eval): Do not make a copy of the expression string. commit e1c80caf88b4b321bdb11353dd5ddb7b092fd3bf Author: Hui Zhu Date: Tue Mar 12 15:44:03 2013 +0000 2013-03-12 Hui Zhu * dwarf2loc.c (dwarf2_compile_expr_to_ax): Update error message. commit 50c4866178fc38a24bb03318019d6eea064658cd Author: eager Date: Tue Mar 12 15:19:23 2013 +0000 Eliminate warning message. * opcodes/mips-dis.c (print_insn_args): Modify def of reg. commit 252bf8675075ff9aeb334e751c95b4054178de6e Author: Hui Zhu Date: Tue Mar 12 14:44:53 2013 +0000 2013-03-12 Yao Qi Hui Zhu * dwarf2loc.c (access_memory): Change nbits to nbytes in gdb_assert. (dwarf2_compile_expr_to_ax): Call access_memory in DW_OP_deref and DW_OP_deref_size. commit 9f8dcb69d91a9850b4db6e17fc3fef53bb2ef850 Author: Paul N. Hilfinger Date: Tue Mar 12 09:03:05 2013 +0000 Allow 'thread' to be used as a variable name in expressions. GDB treats the identifiers 'if', 'thread', and 'task' unconditionally as expression delimiters in Ada mode, which is correct for 'if' and 'task', but wrong for 'thread' in cases such as print thread Borrowing from c-exp.y, we observe that 'thread' must be followed by numerals, whereas identifiers never are and treat them as delimiters only in that case. In the process, the current also refactors and incidentally fixes the code for rewinding the input to before the delimiting tokens. For example, the code watch expr if i > 2 fails because the input is only rewound to just before the 'i', leaving the 'if' as part of the expression (and thus making the rest look like trailing junk rather than a conditional clause). gdb/ChangeLog: * ada-lex.l (rules): Only recognize 'thread' as a delimiter when followed by numerals, as for c-exp.y. Use new rewind_to_char function to rewind the input for expression-delimiting tokens. (rewind_to_char): New function. gdb/testsuite/ChangeLog: * gdb.ada/expr_delims.exp: New file. * gdb.ada/expr_delims/foo.adb: New file. * gdb.ada/expr_delims/pck.ads: New file. * gdb.ada/expr_delims/pck.adb: New file. commit 0368927dfbb44a481c95945d3db9ea33604e5287 Author: Sandra Loosemore Date: Tue Mar 12 02:41:26 2013 +0000 2013-03-11 Sebastian Huber include/ * opcode/nios2.h (OPX_WRPRS): New define. (OP_MATCH_WRPRS): Likewise. opcodes/ * nios2-opc.c (nios2_builtin_opcodes): Add entry for wrprs. gas/ * config/tc-nios2.c (nios2_assemble_args_ds): New function. (nios2_arg_info_structs): Add "d,s" and "d,s,E" entries. gas/testsuite/ * gas/nios2/nios2.exp: Run wrprs. * gas/nios2/wrprs.d: New file. * gas/nios2/wrprs.s: Likewise. commit b53c0bdc3ff25a4f10727642ffab066a56806b8e Author: Sandra Loosemore Date: Tue Mar 12 02:20:08 2013 +0000 2013-03-11 Sebastian Huber include/ * opcode/nios2.h (OP_RDPRS): New define. (OP_MATCH_RDPRS): Likewise. opcodes/ * nios2-opc.c (nios2_builtin_opcodes): Add entry for rdprs. gas/testsuite/ * gas/nios2/nios2.exp: Run rdprs. * gas/nios2/rdprs.d: New file. * gas/nios2/rdprs.s: Likewise. commit 230d65ceda682d831b0c5f223c2a96856b15a424 Author: Sandra Loosemore Date: Tue Mar 12 01:41:41 2013 +0000 2013-03-11 Sebastian Huber opcodes/ * nios2-opc.c (nios2_builtin_regs): Add sstatus alias for ba register. gas/testsuite/ * gas/nios2/nios2.exp: Run registers. * gas/nios2/registers.d: New file. * gas/nios2/registers.s: Likewise. commit 437f6c01301c4b7e1a57a1ace6b42c6275f1f2cb Author: gdbadmin Date: Tue Mar 12 00:00:37 2013 +0000 *** empty log message *** commit 40a4235fc944b72b46570509774f9b12e3c91619 Author: Alan Modra Date: Mon Mar 11 23:00:05 2013 +0000 daily update commit 408160ddf788972cdee8be708eeb5359b1a6dbb4 Author: Eli Zaretskii Date: Mon Mar 11 19:43:52 2013 +0000 * gdb.texinfo (General Query Packets): Don't use colon in index entries visible to Info format. commit 180315dc45822dbe361d786314f62418602f8d61 Author: Keith Seitz Date: Mon Mar 11 19:02:21 2013 +0000 * watchpoint.exp (test_no_hw_watchpoints): Add test using both condition and thread. Then delete the watchpoint. ----------------------------------------------------------------------- hooks/post-receive -- Repository for Project Archer.