From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12639 invoked by alias); 16 Sep 2009 18:18:02 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 12623 invoked by uid 22791); 16 Sep 2009 18:18:01 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_33,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Subject: Re: Patch for pascal-dynamic arrays From: Joost van der Sluis To: Project Archer Cc: Jan Kratochvil In-Reply-To: <20090916154453.GA23913@host0.dyn.jankratochvil.net> References: <1252939529.28930.33.camel@wsjoost.cnoc.lan> <20090916154453.GA23913@host0.dyn.jankratochvil.net> Content-Type: text/plain Date: Wed, 16 Sep 2009 18:18:00 -0000 Message-Id: <1253125058.1180.17.camel@wsjoost.cnoc.lan> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Language-Detected: en X-Spam-Scanned: InterNLnet Mail Scan System V2.03 X-SW-Source: 2009-q3/txt/msg00225.txt.bz2 On Wed, 2009-09-16 at 17:44 +0200, Jan Kratochvil wrote: > On Mon, 14 Sep 2009 16:45:29 +0200, Joost van der Sluis wrote: > > Attached is the patch I have so far, including some tests. > > Please fix it so that it builds with -O2 -Wall -Werror, it also does not > follow the GNU coding style (such as space after a function name). Thanks for your comments and your patch. I had tested everything without optimisation (for debugging) and -Werror because that doesn't compile on windows. > Then also please check regressions of the testsuite - `make -C gdb check' and > comparing gdb.sum before/after the patch. About the testsuite... it takes ages to complete. Is there some way to run just one test (or just one .exp test-file?) > I had to do some of these fixes but it has too many regressions. I don't know anything about the GNU coding style, in fact, I know nothing about c. This is the first c code I wrote in my whole live. That makes fixing the regressions on c-code hard. But I think that there are only a few issues which will fix a lot of regressions. I'll have a look at them. Just a remark: some of your changes in the coding-style are corrections for portions of the code that I copy-pasted from other parts. I use the gdb-code as 'example-code' for the coding style. Is this generally a save assumption, or are there a lot of issues regarding the coding-style in the gdb-code? Joost