From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5160 invoked by alias); 15 May 2010 20:24:35 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 5141 invoked by uid 22791); 15 May 2010 20:24:32 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Subject: Re: Patch for pascal-dynamic arrays From: Joost van der Sluis To: Jan Kratochvil Cc: Project Archer In-Reply-To: <20100514224613.GA3338@host0.dyn.jankratochvil.net> References: <1254326374.2755.14.camel@wsjoost.cnoc.lan> <20091004141705.GA18527@host0.dyn.jankratochvil.net> <1256751286.31305.24.camel@wsjoost.cnoc.lan> <20091030094726.GA29758@host0.dyn.jankratochvil.net> <1257630529.27675.26.camel@wsjoost.cnoc.lan> <1271071502.27845.15.camel@wsjoost.cnoc.lan> <20100412195106.GA32767@host0.dyn.jankratochvil.net> <1271241292.21465.18.camel@wsjoost.cnoc.lan> <20100506230504.GA21919@host0.dyn.jankratochvil.net> <1273874250.9996.33.camel@wsjoost.cnoc.lan> <20100514224613.GA3338@host0.dyn.jankratochvil.net> Content-Type: text/plain Date: Sat, 15 May 2010 20:24:00 -0000 Message-Id: <1273955042.32006.31.camel@wsjoost.cnoc.lan> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Language-Detected: en X-Spam-Scanned: InterNLnet Mail Scan System V2.03 X-SW-Source: 2010-q2/txt/msg00023.txt.bz2 On Sat, 2010-05-15 at 00:46 +0200, Jan Kratochvil wrote: > On Fri, 14 May 2010 23:57:30 +0200, Joost van der Sluis wrote: > > I can't apply it. > > OK, sorry for the inconvenience. No problem, I've got it to work! In principle I did the same as you suggested. Eventually I've applied the patch 'manually' by copy-pasting the right bits. I think there were some eol-differences, or something. But it works great. I don't understand the cleanup-bit entirely, but you've found another solution for this problem I didn't think of. Thanks for the help. A few details, though. Take a look a this bug-report (http://sourceware.org/bugzilla/show_bug.cgi?id=11492) about the identification of arrays. It has a better fix for that, and it avoids problems when merging this later. And when you do a 'print s' when the breakpoint is before line 80. (In arrays.pas) you get 'Object is not allocated'. In theory this is true, but unallocated strings in pascal are handled as empty strings (''). But that's a minor issue that's fixable in p-valprint only. The next challenge is to print individual items from the array. (print DynArrStr[3]). But that didn't work with my patch either. And I think that with your solution it's easier to implement this. Again, thanks for the help, this patch works perfectly. Joost.