public inbox for archer@sourceware.org
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: archer@sourceware.org
Subject: [delayed-symfile] [commit] Fix a regression on delayed retrieving of the unwinding debug info.
Date: Tue, 24 Feb 2009 23:14:00 -0000	[thread overview]
Message-ID: <20090224231429.GC23254@host0.dyn.jankratochvil.net> (raw)

commit 6a37c2b9962258ecf9299cc34a650e64a06acaa5

There was a regression on gdb.base/savedregs.exp.

quick_addrmap/require_partial_symbols should be used even for the unwind debug
info checking as its load has been also delayed by this branch.

Disputable is whether the delayed reading of partial symtabs and unwind info
should not be split in half and read separately on their specific demand.
Assuming their current load together has been decided for the GDB code
simplicity and it has no real performance impact.

	* dwarf2-frame.c: Include addrmap.h.
	(dwarf2_frame_find_fde): Check quick_addrmap, call
	require_partial_symbols.
---
 gdb/dwarf2-frame.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/gdb/dwarf2-frame.c b/gdb/dwarf2-frame.c
index ce11d89..eaa6a13 100644
--- a/gdb/dwarf2-frame.c
+++ b/gdb/dwarf2-frame.c
@@ -38,6 +38,7 @@
 
 #include "complaints.h"
 #include "dwarf2-frame.h"
+#include "addrmap.h"
 
 struct comp_unit;
 
@@ -1499,6 +1500,14 @@ dwarf2_frame_find_fde (CORE_ADDR *pc)
       struct dwarf2_fde *fde;
       CORE_ADDR offset;
 
+      if (objfile->quick_addrmap)
+	{
+	  if (!addrmap_find (objfile->quick_addrmap, *pc))
+	    continue;
+	}
+      /* FIXME: Read-in only .debug_frame/.eh_frame without .debug_info?  */
+      require_partial_symbols (objfile);
+
       fde = objfile_data (objfile, dwarf2_frame_objfile_data);
       if (fde == NULL)
 	continue;
-- 
1.6.0.6

             reply	other threads:[~2009-02-24 23:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-24 23:14 Jan Kratochvil [this message]
2009-02-25  1:47 ` Tom Tromey
2009-02-25 14:47   ` Jan Kratochvil
2009-02-25 16:11   ` Jan Kratochvil
2010-07-14 20:32 ` [delayed-symfile] [commit] Fix a regression on CFI without DIE [Re: [delayed-symfile] [commit] Fix a regression on delayed retrieving of the unwinding debug info.] Jan Kratochvil
2010-07-14 21:20   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090224231429.GC23254@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=archer@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).