From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10568 invoked by alias); 17 Mar 2009 21:39:36 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 10558 invoked by uid 22791); 17 Mar 2009 21:39:33 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Date: Tue, 17 Mar 2009 21:39:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: archer@sourceware.org, Keith Seitz Subject: Re: [expr]-fix [jk-expr-committed] Fix crash on C++ DW_AT_name "". Message-ID: <20090317213919.GA15790@host0.dyn.jankratochvil.net> References: <20090315182943.GA17211@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SW-Source: 2009-q1/txt/msg00390.txt.bz2 On Tue, 17 Mar 2009 22:20:44 +0100, Tom Tromey wrote: > Jan> * gdb/dwarf2read.c (dwarf2_canonicalize_name): Fix crash on NULL name. > > I suspect this should go on archer-keiths-dwarf-names-branch. As I am not sure if the NULL check should not be rather in the caller (and not the callee where did I put it myself) I left this decision on the branch owner. > That's where we imported Daniel's canonicalization patch. It is now contained at least in [expr] (how I shortened called [archer-keiths-expr-cumulative], I hope it is understandable this way). Regards, Jan