public inbox for archer@sourceware.org
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: archer@sourceware.org
Subject: [archer-tromey-call-frame-cfa] [patch] Fix compilation [resent]
Date: Wed, 29 Jul 2009 19:18:00 -0000	[thread overview]
Message-ID: <20090729191819.GA18201@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <20090729191741.GA18146@host0.dyn.jankratochvil.net>

[this time with the patch]

Hi Tom,

dwarf2-frame.c: In function ‘dwarf2_frame_cfa’:
dwarf2-frame.c:1257: error: passing argument 2 of ‘frame_base_is’ discards qualifiers from pointer target type
frame.h:702: note: expected ‘struct frame_base *’ but argument is of type ‘const struct frame_base *’

Fedora 11 gcc-4.4.0-4.x86_64

more curious it did not happen to you.  OK to check-in?


Thanks,
Jan


commit e1849a4a9801313f99fa3faee8a88267651d6217
Author: Jan Kratochvil <jkratoch@host1.dyn.jankratochvil.net>
Date:   Wed Jul 29 21:13:07 2009 +0200

    gdb/
    	* frame.c (frame_base_is): Make the BASE parameter const.
    	* frame.c (frame_base_is): Likewise.

diff --git a/gdb/frame.c b/gdb/frame.c
index c009288..afa6e2a 100644
--- a/gdb/frame.c
+++ b/gdb/frame.c
@@ -1847,7 +1847,7 @@ get_frame_args_address (struct frame_info *fi)
    otherwise.  */
 
 int
-frame_base_is (struct frame_info *fi, struct frame_base *base)
+frame_base_is (struct frame_info *fi, const struct frame_base *base)
 {
   if (fi->base == NULL)
     fi->base = frame_base_find_by_frame (fi);
diff --git a/gdb/frame.h b/gdb/frame.h
index 2c23400..09bf628 100644
--- a/gdb/frame.h
+++ b/gdb/frame.h
@@ -699,6 +699,6 @@ extern struct frame_info *create_new_frame (CORE_ADDR base, CORE_ADDR pc);
 /* Return true if the frame base for frame FI is BASE; false
    otherwise.  */
 
-extern int frame_base_is (struct frame_info *fi, struct frame_base *base);
+extern int frame_base_is (struct frame_info *fi, const struct frame_base *base);
 
 #endif /* !defined (FRAME_H)  */

  reply	other threads:[~2009-07-29 19:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-29 19:17 [archer-tromey-call-frame-cfa] [patch] Fix compilation Jan Kratochvil
2009-07-29 19:18 ` Jan Kratochvil [this message]
2009-07-29 19:23   ` [archer-tromey-call-frame-cfa] [patch] Fix compilation [resent] Tom Tromey
2009-07-29 19:44     ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090729191819.GA18201@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=archer@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).