From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27173 invoked by alias); 16 Sep 2009 18:41:20 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 27159 invoked by uid 22791); 16 Sep 2009 18:41:18 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_33,J_CHICKENPOX_43,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Date: Wed, 16 Sep 2009 18:41:00 -0000 From: Jan Kratochvil To: Joost van der Sluis Cc: Project Archer Subject: Re: Patch for pascal-dynamic arrays Message-ID: <20090916184106.GA2442@host0.dyn.jankratochvil.net> References: <1252939529.28930.33.camel@wsjoost.cnoc.lan> <20090916154453.GA23913@host0.dyn.jankratochvil.net> <1253125058.1180.17.camel@wsjoost.cnoc.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1253125058.1180.17.camel@wsjoost.cnoc.lan> User-Agent: Mutt/1.5.19 (2009-01-05) X-SW-Source: 2009-q3/txt/msg00226.txt.bz2 On Wed, 16 Sep 2009 20:17:38 +0200, Joost van der Sluis wrote: > I had tested everything without optimisation (for debugging) and -Werror > because that doesn't compile on windows. Could you please run it also on GNU/Linux as some final test? If you do not have one available there are various test boxes available at sourceforge.net and similar sites or contact me offlist. Testsuite on GNU/Linux should IMO catch most of the possible regressions. > > Then also please check regressions of the testsuite - `make -C gdb check' and > > comparing gdb.sum before/after the patch. > > About the testsuite... it takes ages to complete. One `make check' should take at most about 20 minutes in worst cases, some 5 minutes should be more normal. Sure it is being run just as a final test. Many FAIL results are normal, just regressions are worth a check. > Is there some way to run just one test (or just one .exp test-file?) I use cd gdb/testsuite make site.exp # needed just once runtest runtest gdb.base/start.exp but probably more correct is to just run: cd gdb/testsuite make check RUNTESTFLAGS="gdb.base/start.exp" > I don't know anything about the GNU coding style, No problem just please try to follow the spacing/indentation of the code around despite it looks unusual. http://www.gnu.org/prep/standards/standards.html#Formatting > But I think that there are only a few issues which will fix a lot of > regressions. I'll have a look at them. Yes, I agree, it may be even a single problem. > Just a remark: some of your changes in the coding-style are corrections > for portions of the code that I copy-pasted from other parts. :-) Some existing GDB code may not follow it but I do not know much of such places offhand. (The GNU coding style really was not a primary concern of my mail, feel free to keep the code parts which you are not sure about the formatting intact.) Thanks, Jan