public inbox for archer@sourceware.org
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Sami Wagiaalla <swagiaal@redhat.com>
Cc: archer@sourceware.org
Subject: [expr-cumulative] Fix return type qualifier
Date: Fri, 23 Oct 2009 19:46:00 -0000	[thread overview]
Message-ID: <20091023194617.GA31024@host0.dyn.jankratochvil.net> (raw)

Hi Sami,

OK to check-in?


gcc-4.1.2-46.el5_4.1.x86_64
errors due to -Werror on:
gdb/dwarf2read.c:3642: warning: type qualifiers ignored on function return type
from code of
e7c98bbe4bea801d53222c3337cbae3f3944547c


Thanks,
Jan

	* dwarf2read.c (dwarf2_read_decl_line): Fix excessive const return
	qualifier.  Fix GNU formatting style.

--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -3357,14 +3357,17 @@ dwarf2_full_name (struct die_info *die, struct dwarf2_cu *cu)
   return name;
 }
 
-/* read the given die's decl_line number. Return -1 if in case of an error */
-static const int dwarf2_read_decl_line (struct die_info *die, struct dwarf2_cu *cu){
+/* Read the given DIE's DW_AT_decl_line number.  Return -1 if in case of an
+   error.  */
+
+static int
+dwarf2_read_decl_line (struct die_info *die, struct dwarf2_cu *cu)
+{
   struct attribute *line_attr;
 
   line_attr = dwarf2_attr (die, DW_AT_decl_line, cu);
-  if (line_attr){
-    return  DW_UNSND (line_attr);
-  }
+  if (line_attr)
+    return DW_UNSND (line_attr);
 
   return -1;
 }

             reply	other threads:[~2009-10-23 19:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-23 19:46 Jan Kratochvil [this message]
2009-10-23 19:55 ` Tom Tromey
2009-10-23 19:59   ` Jan Kratochvil
2009-10-23 20:24     ` Sami Wagiaalla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091023194617.GA31024@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=archer@sourceware.org \
    --cc=swagiaal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).