From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1404 invoked by alias); 8 Dec 2009 19:10:55 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 1392 invoked by uid 22791); 8 Dec 2009 19:10:54 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Date: Tue, 08 Dec 2009 19:10:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: archer@sourceware.org Subject: Re: [delayed-symfile] [commit] Fix objfile_relocate Message-ID: <20091208191043.GA7466@host0.dyn.jankratochvil.net> References: <20091206210612.GA2003@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) X-SW-Source: 2009-q4/txt/msg00087.txt.bz2 On Mon, 07 Dec 2009 18:50:41 +0100, Tom Tromey wrote: > Jan> + /* Alread QUICK_ADDRMAP tiself assumes all sections have the same offset. */ > > Two typos, "Already" and "itself". > > Also, AFAICT gcc only emits text ranges in .debug_aranges. Later found at least dwarf2read.c already commonly assumes SECT_OFF_TEXT is applicable to any types (/data/bss) of inferior objects. Thanks, Jan aaeaa5944753c471599839b077635e4b3717d870 From: Jan Kratochvil Date: Tue, 8 Dec 2009 20:07:13 +0100 Subject: [PATCH] Drop comment. * objfiles.c (objfile_relocate) : Drop the comment. --- gdb/objfiles.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/gdb/objfiles.c b/gdb/objfiles.c index 0f75ebd..2cd1001 100644 --- a/gdb/objfiles.c +++ b/gdb/objfiles.c @@ -633,7 +633,6 @@ objfile_relocate (struct objfile *objfile, struct section_offsets *new_offsets) } } - /* Alread QUICK_ADDRMAP tiself assumes all sections have the same offset. */ if (objfile->quick_addrmap) addrmap_relocate (objfile->quick_addrmap, ANOFFSET (delta, SECT_OFF_TEXT (objfile))); -- 1.6.5.2