public inbox for archer@sourceware.org
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: archer@sourceware.org
Subject: [expr-cumulative] [commit] Remove excessive debug printf's
Date: Fri, 05 Mar 2010 09:31:00 -0000	[thread overview]
Message-ID: <20100305093108.GA3566@host0.dyn.jankratochvil.net> (raw)

commit f78a980bcef45ee74bf267dfcc9633cd9c607a56

Remove excessive debug printf's.

708 FAILs -> 1218 PASSes.

The only remaining regression is the well known:
	gdb.java/jprint.exp: print a java.util.Properties

---
 gdb/eval.c   |    1 -
 gdb/symtab.c |   18 +++++-------------
 2 files changed, 5 insertions(+), 14 deletions(-)

diff --git a/gdb/eval.c b/gdb/eval.c
index 201ead3..524b09e 100644
--- a/gdb/eval.c
+++ b/gdb/eval.c
@@ -1896,7 +1896,6 @@ evaluate_subexp_standard (struct type *expect_type,
 	struct symbol *sym;
 	struct type **arg_types;
 	(*pos) += 3;
-	printf ("TYPE_INSTANCE_LOOKUP\n");
 	arg_types = (struct type **) alloca (TYPE_NFIELDS (expect_type)
 					     * sizeof (struct type *));
 	for (i = 0; i < TYPE_NFIELDS (expect_type); ++i)
diff --git a/gdb/symtab.c b/gdb/symtab.c
index e3822b1..520f5a4 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -1326,13 +1326,9 @@ struct symbol *
 lookup_symbol (const char *name, const struct block *block,
 	       domain_enum domain, int *is_a_field_of_this)
 {
-  printf("symtab.c::lookup_symbol %s\n",name);
-  struct symbol *sym = lookup_symbol_in_language (name, block, domain,
+  return lookup_symbol_in_language (name, block, domain,
 				    current_language->la_language,
 				    is_a_field_of_this);
-  
-  printf("symtab.c::lookup_symbol return %p\n", sym);
-  return sym;
 }
 
 /* Behave like lookup_symbol except that NAME is the natural name
@@ -1348,7 +1344,6 @@ lookup_symbol_aux (const char *name, const struct block *block,
   struct symbol *sym;
   const struct language_defn *langdef;
 
-  printf("symtab.c::lookup_symbol_aux\n", name);
   /* Make sure we do something sensible with is_a_field_of_this, since
      the callers that set this parameter to some non-null value will
      certainly use it later and expect it to be either 0 or 1.
@@ -1361,17 +1356,14 @@ lookup_symbol_aux (const char *name, const struct block *block,
      STATIC_BLOCK or GLOBAL_BLOCK.  */
 
   sym = lookup_symbol_aux_local (name, block, domain, language, is_a_field_of_this);
-  if (sym != NULL){
-    printf("symtab.c::lookup_symbol_aux return 1 %p\n", sym);
+  if (sym != NULL)
     return sym;
-  }
+
   /* this symbol was found to be a member variable
      do not perform the global search. */
-  if (is_a_field_of_this && *is_a_field_of_this){
-    printf("symtab.c::lookup_symbol_aux return 2 %p %d\n", NULL, *is_a_field_of_this);
-        
+  if (is_a_field_of_this && *is_a_field_of_this)
     return NULL;
-  }
+
   /* Now do whatever is appropriate for LANGUAGE to look
      up static and global variables.  */
   langdef = language_def (language);
-- 
1.6.6.1

                 reply	other threads:[~2010-03-05  9:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100305093108.GA3566@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=archer@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).