From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25023 invoked by alias); 29 Apr 2010 16:47:34 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 25006 invoked by uid 22791); 29 Apr 2010 16:47:31 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Date: Thu, 29 Apr 2010 16:47:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: archer@sourceware.org Subject: [next-over-throw2] exception_resume_breakpoint comments Message-ID: <20100429164722.GA5666@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-08-17) X-SW-Source: 2010-q2/txt/msg00015.txt.bz2 Hi, on this branch I have just seen suspicious: static void insert_exception_resume_breakpoint (struct thread_info *tp, struct block *b, struct frame_info *frame, struct symbol *sym) - does not use TP at all. Then clear_thread_inferior_resources now clears tp->step_resume_breakpoint. To make tp->exception_resume_breakpoint on par with existing tp->step_resume_breakpoint IMO clear_thread_inferior_resources should clear even tp->exception_resume_breakpoint. Unrelated bug is that both these breakpoints should be set as thread-specific. Another unrelated bug is that on a thread exit thread-specific breakpoints are not deleted (one may ask if they should be deleted, though). Fix of these two bugs would simplify clear_thread_inferior_resources to remove even the tp->step_resume_breakpoint handling from there. To get back in the scope of this specific patch I would just implement: # To make tp->exception_resume_breakpoint on par with existing # tp->step_resume_breakpoint IMO clear_thread_inferior_resources should clear # even tp->exception_resume_breakpoint. Thanks, Jan