From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <archer-return-2018-listarch-archer=sourceware.org@sourceware.org>
Received: (qmail 11469 invoked by alias); 2 Jul 2010 01:29:40 -0000
Mailing-List: contact archer-help@sourceware.org; run by ezmlm
Sender: <archer@sourceware.org>
Precedence: bulk
List-Post: <mailto:archer@sourceware.org>
List-Help: <mailto:archer-help@sourceware.org>
List-Subscribe: <mailto:archer-subscribe@sourceware.org>
List-Id: <archer.sourceware.org>
Received: (qmail 11460 invoked by uid 22791); 2 Jul 2010 01:29:39 -0000
X-SWARE-Spam-Status: No, hits=-4.3 required=5.0
	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>, "Frank Ch. Eigler" <fche@redhat.com>,
        archer@sourceware.org
Subject: Re: PATCH? gdb remote.c: readchar() should pop_target() if
	SERIAL_ERROR?
In-Reply-To: Oleg Nesterov's message of  Friday, 2 July 2010 03:13:02 +0200 <20100702011302.GA24599@redhat.com>
References: <20100702011302.GA24599@redhat.com>
Message-Id: <20100702012933.E576C4C33C@magilla.sf.frob.com>
Date: Fri, 02 Jul 2010 01:29:00 -0000
X-SW-Source: 2010-q3/txt/msg00001.txt.bz2

I don't know that part of the code at all well either.  But your fix looks
clearly correct.  Both code paths leave in the same way (perror_with_name
is a wrapper around error), so their cleanup calls should match.


Thanks,
Roland