public inbox for archer@sourceware.org
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Project Archer <archer@sourceware.org>
Subject: Re: ptrace improvement: PTRACE_O_INHERIT
Date: Sat, 12 Feb 2011 00:59:00 -0000	[thread overview]
Message-ID: <20110212005855.E764C1814A4@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of  Friday, 11 February 2011 21:37:55 +0100 <20110211203755.GA5367@redhat.com>

> Yes, and that is why I asked about TIF_SYSCALL_TRACE. Because to me
> PTRACE_SYSCALL looks like a property/option regardless of implementation
> details.

But it's only if you're looking at implementation details rather than the
userland interface that you'd think any such thing.

> > > Or. Suppose that clone() under PTRACE_O_INHERIT notifies the tracer
> > > (sends SIGCHLD), and the new tracee gets the new PTRACE_O_INHERITed
> > > mark. Then we can implement wait(W_WHO_WAS_CLONNED) which clears
> > > PTRACE_O_INHERITed and reports the new tracee (just in case, this
> > > doesn't need the stopped tracee).
> >
> > I don't really follow this idea at all, sorry.
> 
> I meant, we can intoduce the new W*** flag for do_wait(). If the new
> tracee was PTRACE_O_INHERIT'ed, do_wait() returns its pid.

I still don't understand the proposal.

> Well yes, but /proc/PID/task/ is not convenient and reliable.
> Especially if we do not trace all threads.

Tracing some threads but not all is really an artifact of the ptrace
interface and not something that any real userland debugger-like thing
ever wants to do.

> Damn. I was so unclear. I tried to say: yes, I think PTRACE_O_THREAD_INHERIT
> makes more sense. If nothing else, the tracer doesn't necessarily wants to
> follow forks, this can create the unneeded overhead if it only wants to ptrace
> the sub-threads.
> 
> IOW, I think that we should have both, or PTRACE_O_THREAD_INHERIT only.

That sounds reasonable (which is why I suggested it in the first place ;-).
But, again, we want to see what GDB really wants to use and only add that.

> Or, this option should take "clone_flags" as an argument.

That is far less straightforward to implement in the vanilla kernel as it
stands today, and so really doesn't fall under the "low hanging fruit" rubric.


Thanks,
Roland

  reply	other threads:[~2011-02-12  0:59 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-03 22:39 ptrace improvement ideas Roland McGrath
2011-02-04 18:56 ` Oleg Nesterov
2011-02-04 18:58   ` Roland McGrath
2011-02-07 21:11 ` Jan Kratochvil
2011-02-08  1:58   ` Roland McGrath
2011-02-08 20:41     ` Jan Kratochvil
2011-02-09  2:48       ` Roland McGrath
2011-02-08 21:07     ` Oleg Nesterov
2011-02-08 23:18       ` hw_breakpoint userland interface Roland McGrath
2011-02-10 21:03         ` Oleg Nesterov
2011-02-10 21:14           ` Roland McGrath
2011-02-11 20:17             ` Oleg Nesterov
2011-02-10 20:00 ` ptrace improvement: PTRACE_O_INHERIT Oleg Nesterov
2011-02-11 19:24   ` Roland McGrath
2011-02-11 20:46     ` Oleg Nesterov
2011-02-12  0:59       ` Roland McGrath [this message]
2011-02-12 19:11         ` Oleg Nesterov
2011-02-14 19:31           ` Roland McGrath
2011-02-14 19:46             ` Oleg Nesterov
2011-02-15  0:36               ` Roland McGrath
2011-02-15 13:16                 ` Oleg Nesterov
2011-02-15 21:43                   ` Jan Kratochvil
2011-02-15 21:56                     ` Roland McGrath
2011-02-16 19:42                       ` Oleg Nesterov
2011-02-16 19:45                         ` Roland McGrath
2011-02-16 20:09                           ` Oleg Nesterov
2011-02-16 20:16                             ` Roland McGrath
2011-02-19 19:48                             ` Jan Kratochvil
2011-02-19 20:37                               ` Oleg Nesterov
2011-02-20  8:18                                 ` Jan Kratochvil
2011-02-20 21:05                                   ` Oleg Nesterov
2011-02-21 19:54                                 ` Roland McGrath
2011-02-22 19:39                                   ` Oleg Nesterov
2011-02-22 20:49                                     ` Roland McGrath
2011-02-22 21:10                                       ` Oleg Nesterov
2011-02-22 22:16                                         ` Roland McGrath
2011-02-21 19:44                               ` Roland McGrath
2011-02-15 22:02                     ` Roland McGrath
2011-02-16 16:02                       ` Jan Kratochvil
2011-02-16 18:28                         ` Roland McGrath
2011-02-16 20:00                           ` Oleg Nesterov
2011-02-16 20:07                             ` Roland McGrath
2011-02-16 20:32                               ` Oleg Nesterov
2011-02-16 19:48                       ` Oleg Nesterov
2011-02-16 20:02                         ` Roland McGrath
2011-02-16 20:15                           ` Oleg Nesterov
2011-02-16 20:31                             ` Roland McGrath
2011-02-16 21:04                               ` Oleg Nesterov
2011-02-16 21:51                                 ` Roland McGrath
2011-02-16 19:38                     ` Oleg Nesterov
2011-02-16 19:40                       ` Roland McGrath
2011-02-15 22:17                   ` Roland McGrath
2011-02-16 20:48                     ` Oleg Nesterov
2011-02-16 11:31 ` ptrace improvement ideas (QPassSignals) Jan Kratochvil
2011-02-16 18:36   ` Roland McGrath
2011-02-16 20:21     ` Oleg Nesterov
2011-02-18 20:24       ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110212005855.E764C1814A4@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=archer@sourceware.org \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).