From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: archer@sourceware.org
Cc: Gary Benson <gbenson@redhat.com>
Subject: Re: Improved linker-debugger interface
Date: Tue, 07 Jun 2011 16:58:00 -0000 [thread overview]
Message-ID: <20110607165828.GA28638@host1.jankratochvil.net> (raw)
In-Reply-To: <20110525153649.GB3149@redhat.com>
On Wed, 25 May 2011 17:36:50 +0200, Gary Benson wrote:
> --- a/sysdeps/generic/ldsodefs.h
> +++ b/sysdeps/generic/ldsodefs.h
[...]
> +/* The dynamic linker calls this function after having changed any
> + shared object mappings. */
> +extern void _dl_debug_state_extended (Lmid_t ns, struct r_debug *r)
> + internal_function;
> +
[...]
> --- a/elf/dl-debug.c
> +++ b/elf/dl-debug.c
> @@ -76,3 +76,19 @@ _dl_debug_state (void)
> {
> }
> rtld_hidden_def (_dl_debug_state)
> +
> +
> +/* This function exists solely to contain SystemTap probes which the
> + debugger can set breakpoints on. */
Here should be also `internal_function' otherwise on i686 it will:
dl-debug.c:84:1: error: conflicting types for '_dl_debug_state_extended'
../sysdeps/generic/ldsodefs.h:963:13: note: previous declaration of '_dl_debug_state_extended' was here
> +void
> +_dl_debug_state_extended (Lmid_t ns, struct r_debug *r)
> +{
> + if (r->r_state == RT_CONSISTENT)
> + {
> + LIBC_PROBE (r_debug_mod_complete, 2, ns, r);
> + }
> + else
> + {
> + LIBC_PROBE (r_debug_mod_starting, 2, ns, r);
> + }
> +}
Thanks,
Jan
next prev parent reply other threads:[~2011-06-07 16:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 15:37 Gary Benson
2011-05-25 18:21 ` Tom Tromey
2011-05-26 17:02 ` Gary Benson
2011-05-26 17:25 ` Tom Tromey
2011-05-26 17:37 ` Paul Pluzhnikov
2011-05-26 17:47 ` Tom Tromey
2011-05-26 21:07 ` Tom Tromey
2011-05-31 16:25 ` Gary Benson
2011-05-31 19:46 ` Tom Tromey
2011-05-31 20:41 ` Paul Pluzhnikov
2011-05-31 20:46 ` Tom Tromey
2011-05-31 21:05 ` Paul Pluzhnikov
2011-06-02 23:56 ` Tom Tromey
2011-06-07 16:58 ` Jan Kratochvil [this message]
2011-06-08 10:56 ` Gary Benson
2011-06-01 1:24 Frank Ch. Eigler
2011-06-02 23:56 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110607165828.GA28638@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=archer@sourceware.org \
--cc=gbenson@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).