From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24869 invoked by alias); 8 Jun 2011 10:56:36 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 24857 invoked by uid 22791); 8 Jun 2011 10:56:35 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,SPF_FAIL X-Spam-Check-By: sourceware.org Date: Wed, 08 Jun 2011 10:56:00 -0000 From: Gary Benson To: archer@sourceware.org Subject: Re: Improved linker-debugger interface Message-ID: <20110608102321.GB2680@redhat.com> Mail-Followup-To: archer@sourceware.org References: <20110525153649.GB3149@redhat.com> <20110607165828.GA28638@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110607165828.GA28638@host1.jankratochvil.net> X-SW-Source: 2011-q2/txt/msg00019.txt.bz2 Jan Kratochvil wrote: > On Wed, 25 May 2011 17:36:50 +0200, Gary Benson wrote: > > --- a/sysdeps/generic/ldsodefs.h > > +++ b/sysdeps/generic/ldsodefs.h > [...] > > +/* The dynamic linker calls this function after having changed any > > + shared object mappings. */ > > +extern void _dl_debug_state_extended (Lmid_t ns, struct r_debug *r) > > + internal_function; > > + > [...] > > --- a/elf/dl-debug.c > > +++ b/elf/dl-debug.c > > @@ -76,3 +76,19 @@ _dl_debug_state (void) > > { > > } > > rtld_hidden_def (_dl_debug_state) > > + > > + > > +/* This function exists solely to contain SystemTap probes which the > > + debugger can set breakpoints on. */ > > Here should be also `internal_function' otherwise on i686 it will: > > dl-debug.c:84:1: error: conflicting types for '_dl_debug_state_extended' > ../sysdeps/generic/ldsodefs.h:963:13: note: previous declaration of '_dl_debug_state_extended' was here > > > +void > > +_dl_debug_state_extended (Lmid_t ns, struct r_debug *r) ... Thanks Jan. Cheers, Gary -- http://gbenson.net/