From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15726 invoked by alias); 6 Mar 2012 21:50:40 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 15703 invoked by uid 22791); 6 Mar 2012 21:50:39 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Date: Tue, 06 Mar 2012 21:50:00 -0000 From: Joel Brobecker To: Keith Seitz Cc: archer@sourceware.org Subject: Re: [Archer] Re: [Archer] Re: [Archer] Stop the Insanity! Linespec Rewrite Message-ID: <20120306215019.GQ2867@adacore.com> References: <4F501EC1.3050104@redhat.com> <20120302190658.GH2867@adacore.com> <4F514E30.7070400@redhat.com> <20120306173945.GP2867@adacore.com> <4F564C6F.60001@redhat.com> <4F56671E.4000905@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F56671E.4000905@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-SW-Source: 2012-q1/txt/msg00023.txt.bz2 > This turned out to be pretty simple. collect_symbols was > unconditionally adding all matching symbols to the results, which is > appropriate only with DECODE_LINE_LIST_MODE. [I admit, I didn't > actually know one could do that. "list a_global_variable" Learn > something new everyday!] Ah, yes, I came across the very same problem when I was helping Tom with the Ada regressions with his linespec patche series... > I pushed a patch for this. It now passes all of your new tests. > > Any others? I do not think so. That was fast! I will make sure to update my sources and test again ASAP, hopefully this evening or tomorrow. Great responsiveness, Keith. And also, the fact that you were able to fix the problems easily seems to confirm the inherent quality of your new code. It's great. Cheers, -- Joel