From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31436 invoked by alias); 8 Mar 2012 03:02:28 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 31415 invoked by uid 22791); 8 Mar 2012 03:02:26 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Date: Thu, 08 Mar 2012 03:02:00 -0000 From: Joel Brobecker To: Keith Seitz Cc: archer@sourceware.org Subject: Re: Stop the Insanity! Linespec Rewrite Message-ID: <20120308030202.GD2867@adacore.com> References: <4F564C6F.60001@redhat.com> <4F56671E.4000905@redhat.com> <20120306215019.GQ2867@adacore.com> <20120307001119.GU2867@adacore.com> <4F56B4D5.4070700@redhat.com> <20120307012603.GX2867@adacore.com> <871up4scgs.fsf@fleche.redhat.com> <87fwdkqwut.fsf@fleche.redhat.com> <20120307153909.GY2867@adacore.com> <4F57CEF1.50001@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F57CEF1.50001@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-SW-Source: 2012-q1/txt/msg00033.txt.bz2 > Actually it was a failure on the new parser to properly deal with > parse_to_comma_and_eval (used in linespec_expression_to_pc), which > retokenizes the input based on whitespace. Our emails crossed paths :-) > Could you verify that I didn't break anything else? Of course. You've got to love git and the fact that you're making fast-forward pushes (instead of rebasing + forced push), which hugely simplifies my task. Anyway, all this rambling to say that the testsuite runs clean. I also forgot to say that your patch improves the diagnostic in the following case: --- Regression: KB27-008__file_star_line_linespec:break foo.adb:*:3 - Could not match y-or-n question Function "*:3" not defined in "foo.adb". Make breakpoint pending on future shared library load - Against input line Function "*" not defined in "foo.adb". Make breakpoint pending on future shared library load The difference is that is says function "*" instead of "*:3" when doing: (gdb) break foo.adb:*:3 For the record, "*" used to be a way in AdaCore's debugger to say "break on all instances". It was a long long time ago, and Paul and I killed that syntax since then, and we have a check to verify that it returns an error. I wonder if it would work with an operator, though... I think you'd need the double-quotes. Aha! (gdb) b ops.adb:"*":35 Breakpoint 1 at 0x40217a: file /[...]/ops.adb, line 35. (gdb) b ops.adb:*:35 Function "*:35" not defined in "ops.adb". Make breakpoint pending on future shared library load? (y or [n]) n And your debugger behaves beautifully as well: (gdb) b ops.adb:"*":35 Breakpoint 1 at 0x40217a: file /[...]/ops.adb, line 35. (gdb) b ops.adb:*:35 Function "*" not defined in "ops.adb". Make breakpoint pending on future shared library load? (y or [n]) n (this is using the gdb.ada/operator_bp testcase). I need to augment that testcase, now :-/. -- Joel