From: Jonas Maebe <jonas.maebe@elis.ugent.be>
To: archer@sourceware.org
Subject: Re: Fixes for Mac OS X/x86 building/running
Date: Thu, 12 Mar 2009 23:07:00 -0000 [thread overview]
Message-ID: <20685469-4CEE-4B23-B8E7-F769ADB1C0E0@elis.ugent.be> (raw)
In-Reply-To: <m3tz5yv0e6.fsf@fleche.redhat.com>
On 12 Mar 2009, at 23:31, Tom Tromey wrote:
> Just FYI, the machoread.c patch won't apply upstream, because we
> haven't submitted the delayed partial symbol reading patch yet.
Ah, so that one is actually appropriate for this list :)
> I suspect you must have added the NULL in the wrong spot, because that
> line is:
>
> (*objfile->sf->sym_read) (objfile, mainline);
>
> ... but the new field is the next field in the struct,
> sym_read_psymbols.
You're absolutely right, thanks! That's also the cause of the problems
I experienced. Once I put the function pointer in the right place,
everything started to work fine. I'll send a fixed patch tomorrow.
Jonas
PS: I've mailed the request for the copyright assignment form.
next prev parent reply other threads:[~2009-03-12 23:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 19:41 Jonas Maebe
2009-03-12 18:30 ` Jonas Maebe
2009-03-12 18:41 ` Joel Brobecker
2009-03-12 19:28 ` Jonas Maebe
2009-03-12 20:56 ` Tom Tromey
2009-03-12 21:45 ` Jonas Maebe
2009-03-12 22:19 ` [Archer] " Joel Brobecker
2009-03-12 22:33 ` Tom Tromey
2009-03-12 23:07 ` Jonas Maebe [this message]
2009-03-12 23:25 ` Tom Tromey
2009-03-12 22:40 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20685469-4CEE-4B23-B8E7-F769ADB1C0E0@elis.ugent.be \
--to=jonas.maebe@elis.ugent.be \
--cc=archer@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).