From: Sami Wagiaalla <swagiaal@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Project Archer <archer@sourceware.org>
Subject: Re: using directive patch
Date: Mon, 08 Sep 2008 15:18:00 -0000 [thread overview]
Message-ID: <48C54209.9080403@redhat.com> (raw)
In-Reply-To: <m3r67ytngk.fsf@fleche.redhat.com>
Tom Tromey wrote:
>>>>>> "Sami" == Sami Wagiaalla <swagiaal@redhat.com> writes:
>
> Sami> The above is the only variation I test. There is more to come, but I
> Sami> wanted to get some feed back early on.
>
> I don't understand it all, but it looks reasonable to me.
>
> There are a number of formatting nits, but that is nothing much to
> worry about. The GNU Coding Standards cover how this code ought to
> look.
>
> It would be nice if this could be done without a new global variable,
> but I understand that you're copying existing practice.
>
Yes exactly I was copying parameters and local variables.
> One important thing for merging (to archer trunk) is test cases.
> Ideally the tests would specify expected behavior, both ordinary and
> error cases.
>
Coming right up.
next prev parent reply other threads:[~2008-09-08 15:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-03 18:07 Sami Wagiaalla
2008-09-05 19:15 ` Tom Tromey
2008-09-08 15:18 ` Sami Wagiaalla [this message]
2008-09-07 18:37 ` Jan Kratochvil
2008-09-08 15:16 ` Sami Wagiaalla
2008-09-08 15:31 ` Jan Kratochvil
2008-09-18 21:14 ` DW_TAG_imported_declaration DW_TAG_base_type w/o DW_AT_name [Re: using directive patch] Jan Kratochvil
2009-06-16 15:14 ` Sami Wagiaalla
2009-06-16 18:16 ` Tom Tromey
2009-06-16 20:38 ` Jan Kratochvil
2009-06-17 15:02 ` Sami Wagiaalla
2009-06-17 16:42 ` Tom Tromey
2009-06-19 16:46 ` Jan Kratochvil
2008-09-10 19:03 ` using directive patch Sami Wagiaalla
2008-09-16 16:54 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C54209.9080403@redhat.com \
--to=swagiaal@redhat.com \
--cc=archer@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).