From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11033 invoked by alias); 8 Sep 2008 15:18:09 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 11023 invoked by uid 22791); 8 Sep 2008 15:18:08 -0000 X-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_20,KAM_MX,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Message-ID: <48C54209.9080403@redhat.com> Date: Mon, 08 Sep 2008 15:18:00 -0000 From: Sami Wagiaalla User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Tom Tromey CC: Project Archer Subject: Re: using directive patch References: <48BED230.1070209@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-SW-Source: 2008-q3/txt/msg00185.txt.bz2 Tom Tromey wrote: >>>>>> "Sami" == Sami Wagiaalla writes: > > Sami> The above is the only variation I test. There is more to come, but I > Sami> wanted to get some feed back early on. > > I don't understand it all, but it looks reasonable to me. > > There are a number of formatting nits, but that is nothing much to > worry about. The GNU Coding Standards cover how this code ought to > look. > > It would be nice if this could be done without a new global variable, > but I understand that you're copying existing practice. > Yes exactly I was copying parameters and local variables. > One important thing for merging (to archer trunk) is test cases. > Ideally the tests would specify expected behavior, both ordinary and > error cases. > Coming right up.