Branch merging for demo

Branch merging for demo

[Rick Moseley]

OK guys, here is the branches I have merged so far using the 
"archer-tromey-python" as the base branch:

archer-pmuldoon-exception-rewind
archer-jkratochvil-vla branch
archer-tromey-delayed-symfile
archer-sergio-catch-syscall

Jan has given me the go ahead to merge his "archer-jankratochvil-misc" 
branch, but I am holding off for a bit on that as I had some problems 
merging the first time.  The results of the merged and subsequent "make 
check" results.  Evidently I screwed something up mering the last branch 
on the list as the test hangs my system.  The results are at the end of 
the list here.  I suspect something in breakpoint.c got scrogged, not 
sure.  I am trying to track that down.

If anyone wants to take a look they can check out 
"archer-rmoseley-demo-merge" branch as i have checked in everything I 
have dome so far.

Thanks,

Rick

Pulled archer-tromey-python branch, compiled and tested with these results:

 === gdb Summary ===

# of expected passes            12739
# of unexpected failures        240
# of expected failures          42
# of known failures             56
# of unresolved testcases       11
# of untested testcases         2
# of unsupported tests          51

Merged the archer-pmuldoon-exception-rewind branch, compiled and tested 
with these results:


                === gdb Summary ===

# of expected passes            12754
# of unexpected failures        143
# of expected failures          42
# of known failures             56
# of unresolved testcases       11
# of untested testcases         2
# of unsupported tests          51

Merged the archer-jkratochvil-vla branch, compiled and tested with these 
results:

                === gdb Summary ===

# of expected passes            12780
# of unexpected failures        244
# of expected failures          42
# of known failures             56
# of unresolved testcases       11
# of untested testcases         4
# of unsupported tests          51

Merged the archer-tromey-delayed-symfile, compiled and tested with these 
results:

                === gdb Summary ===

# of expected passes            12697
# of unexpected failures        242
# of expected failures          42
# of known failures             56
# of unresolved testcases       20
# of untested testcases         4
# of unsupported tests          51

Merged the archer-sergio-catch-syscall branch, compiled and tested with 
these results:

 .
 .
 .
Running ../.././gdb/testsuite/gdb.base/bigcore.exp ...
Running ../.././gdb/testsuite/gdb.base/bitfields.exp ...
Running ../.././gdb/testsuite/gdb.base/bitfields2.exp ...
Running ../.././gdb/testsuite/gdb.base/bitops.exp ...
Running ../.././gdb/testsuite/gdb.base/break-always.exp ...
Running ../.././gdb/testsuite/gdb.base/break.exp ...
ERROR: Delete all breakpoints in delete_breakpoints (timeout)
FAIL: gdb.base/break.exp: break tests suppressed
FAIL: gdb.base/break.exp: (timeout) finish with arguments disallowed
FAIL: gdb.base/break.exp: (timeout) finish from outermost frame disallowed
ERROR: Couldn't send kill to GDB.
ERROR: Delete all breakpoints in delete_breakpoints (timeout)
ERROR: Couldn't send break factorial to GDB.
WARNING: remote_expect statement without a default case?!
FAIL: gdb.base/break.exp: run to factorial(6) (timeout)
ERROR: Couldn't send continue to GDB.
ERROR: Couldn't send backtrace to GDB.
ERROR: Couldn't send next to GDB.
ERROR: Delete all breakpoints in delete_breakpoints (timeout)
ERROR: Couldn't send next to GDB.
ERROR: Couldn't send backtrace to GDB.
ERROR: Couldn't send continue to GDB.
Running ../.././gdb/testsuite/gdb.base/call-ar-st.exp ...
FAIL: gdb.base/call-ar-st.exp: print print_double_array(double_array) 
(pattern 5 + sentinel) (timeout)
FAIL: gdb.base/call-ar-st.exp: print print_char_array(char_array) 
(pattern 2) (timeout)
ERROR: Couldn't send tbreak 1216 to GDB.
FAIL: gdb.base/call-ar-st.exp: continue to 1216 (pattern 1) (timeout)
ERROR: Couldn't send tbreak 1220 to GDB.
FAIL: gdb.base/call-ar-st.exp: continuing to breakpoint 1220 (pattern 1) 
(timeout)
FAIL: gdb.base/call-ar-st.exp: step inside print_all_arrays (timeout)
FAIL: gdb.base/call-ar-st.exp: next over print_int_array in 
print-all_arrays (timeout)
FAIL: gdb.base/call-ar-st.exp: print print_double_array(array_d) 
(pattern 1) (timeout)
ERROR: Couldn't send tbreak 1236 to GDB.
FAIL: gdb.base/call-ar-st.exp: continuing to 1236 (pattern 1) (timeout)
FAIL: gdb.base/call-ar-st.exp: (timeout) print sum_array_print(10, 
*list1, *list2, *list3, *list4)
FAIL: gdb.base/call-ar-st.exp: next to 1237(timeout)
FAIL: gdb.base/call-ar-st.exp: (timeout) print print_array_rep(*list1, 
*list2, *list3)
ERROR: Couldn't send tbreak 1241 to GDB.
FAIL: gdb.base/call-ar-st.exp: (timeout) continue to 1241
ERROR: Couldn't send break sum_array_print to GDB.
ERROR: Couldn't send continue to GDB.
ERROR: Couldn't send tbreak 1281 to GDB.
FAIL: gdb.base/call-ar-st.exp: (timeout) continue to 1281
FAIL: gdb.base/call-ar-st.exp: print print_small_structs (pattern 1) 
(timeout)
FAIL: gdb.base/call-ar-st.exp: (timeout) compute_with_small_structs(20)
FAIL: gdb.base/call-ar-st.exp: print print_ten_doubles (pattern 1) (timeout)
ERROR: Couldn't send tbreak 1286 to GDB.
ERROR: Couldn't send continue to GDB.
ERROR: Couldn't send tbreak print_long_arg_list to GDB.
FAIL: gdb.base/call-ar-st.exp: step into print_long_arg_list (timeout)
FAIL: gdb.base/call-ar-st.exp: print print_small_structs from 
print_long_arg_list (pattern 1) (timeout)
ERROR: Couldn't send tbreak 1300 to GDB.
ERROR: Couldn't send continue to GDB.
FAIL: gdb.base/call-ar-st.exp: step into init_bit_flags_combo (timeout)
FAIL: gdb.base/call-ar-st.exp: (timeout) print_bit_flags_combo from 
init_bit_flags_combo
ERROR: Couldn't send tbreak 1305 to GDB.
ERROR: Couldn't send continue to GDB.
FAIL: gdb.base/call-ar-st.exp: print print_long_arg_list (pattern 1) 
(timeout)
ERROR: Couldn't send tbreak 1311 to GDB.
ERROR: Couldn't send continue to GDB.
FAIL: gdb.base/call-ar-st.exp: (timeout) sum_struct_print(10, *struct1, 
*struct2, *struct3, *struct4)
FAIL: gdb.base/call-ar-st.exp: print print_struct_rep(*struct1, 
*struct2, *struct3) (pattern 1) (timeout)
FAIL: gdb.base/call-ar-st.exp: (timeout) print_one_large_struct(*list1)
Running ../.././gdb/testsuite/gdb.base/call-rt-st.exp ..


At this point the test totally hung my system as it had consumed all of 
my memory and cpu time.  I had to do a power-off to get my system back.

Re: Branch merging for demo

[Jan Kratochvil]

On Thu, 18 Dec 2008 17:16:47 +0100, Rick Moseley wrote:
> Pulled archer-tromey-python branch, compiled and tested with these results:
>
> === gdb Summary ===
>
> # of expected passes            12739
> # of unexpected failures        240
> # of expected failures          42
> # of known failures             56
> # of unresolved testcases       11
> # of untested testcases         2
> # of unsupported tests          51
>
> Merged the archer-pmuldoon-exception-rewind branch, compiled and tested  
> with these results:
>
>
>                === gdb Summary ===
>
> # of expected passes            12754
> # of unexpected failures        143
> # of expected failures          42
> # of known failures             56
> # of unresolved testcases       11
> # of untested testcases         2
> # of unsupported tests          51

Please note comparing the counts is not enough for a regressions verification.
Some of the GDB testcases still have flipping results and some real
regressions had effect on a single testcase so the total count does not say
much.  Recommending to diff the gdb.sum files (doing so by hand).


> At this point the test totally hung my system as it had consumed all of  
> my memory and cpu time.  I had to do a power-off to get my system back.

FYI after crashing my machine several times :-) using now $HOME/bin/runtest:
	#! /bin/sh
	#sync
	ulimit -v 500000
	ulimit -c unlimited
	exec nice /usr/bin/runtest "$@"


Regards,
Jan

[demo-merge] [patch] Regression fix for vla [Re: Branch merging for demo]

[Jan Kratochvil]

[-- Attachment #1: Type: text/plain, Size: 853 bytes --]

On Thu, 18 Dec 2008 17:16:47 +0100, Rick Moseley wrote:
> OK guys, here is the branches I have merged so far using the  
> "archer-tromey-python" as the base branch:
[...]
> archer-jkratochvil-vla branch

The merge had a regression against the archer-jkratochvil-vla branch:
FAIL: gdb.fortran/dynamic.exp: p varx unallocated
FAIL: gdb.fortran/dynamic.exp: p varv unassociated
FAIL: gdb.fortran/dynamic.exp: p varv deassociated
FAIL: gdb.fortran/dynamic.exp: p varx deallocated
FAIL: gdb.fortran/dynamic.exp: p vary
FAIL: gdb.fortran/dynamic.exp: p varw
FAIL: gdb.fortran/dynamic.exp: p varw filled

Attached a fix, please check it in incl. the demo machine update.

Regression-tested archer-rmoseley-demo-merge on x86_64-unknown-linux-gnu.
While it is a change in a generic code I doubt it can affect the other merged
branches in any way.


Thanks,
Jan

[-- Attachment #2: regression-git.patch --]
[-- Type: text/plain, Size: 796 bytes --]

Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Date:   Sun Jan 18 18:17:37 2009 +0100

    Fix a archer-jankratochvil-vla -> archer-rmoseley-demo-merge merge regression.
    
    I do not find any conflict with the other merged patches at that place.

diff --git a/gdb/valops.c b/gdb/valops.c
index c3935ef..5c2af5e 100644
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -677,10 +677,8 @@ value_fetch_lazy (struct value *val)
 {
   if (VALUE_LVAL (val) == lval_memory)
     {
-      CORE_ADDR addr = value_address (val);
-      int length = TYPE_LENGTH (check_typedef (value_enclosing_type (val)));
+      CORE_ADDR addr = VALUE_ADDRESS (val);
 
-      addr = VALUE_ADDRESS (val);
       if (object_address_get_data (value_type (val), &addr))
 	{
 	  struct type *type = value_enclosing_type (val);

[demo-merge] [patch] Regression fix for vla [Re: Branch merging for demo]

[Rick Moseley]

Done and rebuilt.

Thanks Jan.

Jan Kratochvil wrote:
> On Thu, 18 Dec 2008 17:16:47 +0100, Rick Moseley wrote:
>   
>> OK guys, here is the branches I have merged so far using the  
>> "archer-tromey-python" as the base branch:
>>     
> [...]
>   
>> archer-jkratochvil-vla branch
>>     
>
> The merge had a regression against the archer-jkratochvil-vla branch:
> FAIL: gdb.fortran/dynamic.exp: p varx unallocated
> FAIL: gdb.fortran/dynamic.exp: p varv unassociated
> FAIL: gdb.fortran/dynamic.exp: p varv deassociated
> FAIL: gdb.fortran/dynamic.exp: p varx deallocated
> FAIL: gdb.fortran/dynamic.exp: p vary
> FAIL: gdb.fortran/dynamic.exp: p varw
> FAIL: gdb.fortran/dynamic.exp: p varw filled
>
> Attached a fix, please check it in incl. the demo machine update.
>
> Regression-tested archer-rmoseley-demo-merge on x86_64-unknown-linux-gnu.
> While it is a change in a generic code I doubt it can affect the other merged
> branches in any way.
>
>
> Thanks,
> Jan
>