From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4138 invoked by alias); 17 Mar 2009 22:00:09 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 4107 invoked by uid 22791); 17 Mar 2009 22:00:07 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Message-ID: <49C01D57.2040202@redhat.com> Date: Tue, 17 Mar 2009 22:00:00 -0000 From: Keith Seitz User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: Tom Tromey CC: archer@sourceware.org Subject: Re: [expr]-fix [jk-expr-committed] Fix crash on C++ DW_AT_name "". References: <20090315182943.GA17211@host0.dyn.jankratochvil.net> <20090317213919.GA15790@host0.dyn.jankratochvil.net> In-Reply-To: <20090317213919.GA15790@host0.dyn.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2009-q1/txt/msg00393.txt.bz2 Jan Kratochvil wrote: > On Tue, 17 Mar 2009 22:20:44 +0100, Tom Tromey wrote: >> Jan> * gdb/dwarf2read.c (dwarf2_canonicalize_name): Fix crash on NULL name. >> >> I suspect this should go on archer-keiths-dwarf-names-branch. > > As I am not sure if the NULL check should not be rather in the caller (and not > the callee where did I put it myself) I left this decision on the branch > owner. I was curious about how it was possible to even tickle this bug, but I don't think the proposed patch is neither unreasonable nor incorrect. Just defensive. [Which is good IMO.] >> That's where we imported Daniel's canonicalization patch. > > It is now contained at least in [expr] (how I shortened called > [archer-keiths-expr-cumulative], I hope it is understandable this way). It was my intent to deprecate all the previous expr-related branches, for better or worse. There's just too much interaction between them. But, yeah, you are right: My original import is on that branch. Additional fixes are already in expr-cumulative, though. I can commit this to expr-cumulative, if you want me to... Keith