From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23189 invoked by alias); 2 Nov 2009 13:48:26 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 23180 invoked by uid 22791); 2 Nov 2009 13:48:25 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Message-ID: <4AEEE320.20206@redhat.com> Date: Mon, 02 Nov 2009 13:48:00 -0000 From: Phil Muldoon User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-2.7.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4 MIME-Version: 1.0 To: Tom Tromey CC: Project Archer Subject: Re: [patch] Fix python/10805 References: <4ADDBEFF.4080805@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2009-q4/txt/msg00035.txt.bz2 On 10/30/2009 10:18 PM, Tom Tromey wrote: >>>>>> "Phil" == Phil Muldoon writes: >>>>>> > Phil> This patch fixes python/10805. When fields were being constructed, the > Phil> convert_fields function was not checking if the type was a class > Phil> before determining if it was a base class. Added a check to gate this > Phil> behaviour. > > Looks good, thanks. > > Phil> Additionally, I started a testsuite for Python types. This suite only > Phil> tests for this regression, but it can be expanded later, in separate > Phil> efforts. > Thanks. Committed: as dad6b53fe4a6df586dcd0a57e2151e7663191f18 > Awesome. > > The is_base_class thing isn't upstream. > It would be good to submit all this sometime. > I'll dig out the is_base_class author name and submit the patch and ChangeLog upstream, as well as this patchlet. Cheers, Phil