From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26403 invoked by alias); 5 Jan 2010 14:51:12 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 26388 invoked by uid 22791); 5 Jan 2010 14:51:10 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Message-ID: <4B4351CD.5060804@redhat.com> Date: Tue, 05 Jan 2010 14:51:00 -0000 From: Phil Muldoon User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Lightning/1.0pre Thunderbird/3.0b4 MIME-Version: 1.0 To: Matt McCormick CC: archer@sourceware.org Subject: Re: [PATCH] [python] Add gdb.value_history_count() References: <1262192902-11770-1-git-send-email-matt@mmmccormick.com> <1262193413-14509-1-git-send-email-matt@mmmccormick.com> In-Reply-To: <1262193413-14509-1-git-send-email-matt@mmmccormick.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2010-q1/txt/msg00000.txt.bz2 On 12/30/2009 05:16 PM, Matt McCormick wrote: Looks good. As this is Tom's branch he will have to note whether it can be checked in or not. Some small nits: > gdb/doc/ChangeLog > > 2009-30-12 Matt McCormick > > * doc/gdb.texinfo (Basic Python): Document gdb.value_history_count. As there is a ChangeLog in the doc/ directory, the paths should be relative to the ChangeLog. So in this case, the doc/ prefix is not necessary. > gdb/testsuite/ChangeLog > > 2009-30-12 Matt McCormick > > * testsuite/gdb.python/py-value.exp (test_value_history_count): Test > gdb.value_history_count. Same here with testsuite/. > +@findex gdb.value_history_count > +@defun value_history_count > +Return an int corresponding to the number of entries in the value history > +(@pxref{Value History}). > +@end defun Missing period at the end of that sentence. > > +/* This returns the number of entries in the value history. */ > + > +int get_value_history_count(); > + Need a space before the '('. And git diff --check reports a rogue whitespace ;) git diff --check gdb/testsuite/gdb.python/py-value.exp:277: trailing whitespace. Cheers! Phil