From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10884 invoked by alias); 26 Jan 2010 20:54:09 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 10875 invoked by uid 22791); 26 Jan 2010 20:54:08 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Message-ID: <4B5F5663.6090301@redhat.com> Date: Tue, 26 Jan 2010 20:54:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Lightning/1.0pre Thunderbird/3.0 MIME-Version: 1.0 To: tromey@redhat.com CC: Project Archer Subject: Re: [expr-cumulative] RFA fix PR 9708 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2010-q1/txt/msg00031.txt.bz2 On 01/26/2010 10:02 AM, Tom Tromey wrote: > @@ -2644,6 +2644,13 @@ die_needs_namespace (struct die_info *die, struct dwarf2_cu *cu) > attr = dwarf2_attr (die, DW_AT_external, cu); > if (attr == NULL&& die->parent->tag != DW_TAG_namespace) > return 0; > + /* A variable in a lexical block of some kind does not need a > + namespace, even though in C++ such variables may be > + external and have a mangled name. */ > + if (die->parent->tag == DW_TAG_lexical_block > + || die->parent->tag == DW_TAG_try_block > + || die->parent->tag == DW_TAG_catch_block) > + return 0; > return 1; > } > break; One question: should one be able to print the value of this static OUTSIDE the specific block in which it is defined? "print K::m::themagicstatic"? This would almost certainly be a contrivance on our part for the sake of debugging, but it seems a reasonable thing to be able to do. In any case, I don't have a problem with your patch. Keith