public inbox for archer@sourceware.org
 help / color / mirror / Atom feed
From: Sami Wagiaalla <swagiaal@redhat.com>
To: archer@sourceware.org
Subject: Re: [expr-cumulative] RFA: fix explicit operator parsing
Date: Wed, 27 Jan 2010 18:37:00 -0000	[thread overview]
Message-ID: <4B6088BA.8080305@redhat.com> (raw)
In-Reply-To: <m3ockfe7b7.fsf@fleche.redhat.com>

On 01/27/2010 01:22 PM, Tom Tromey wrote:
> While looking at a bug I found that expr-cumulative does not handle one
> case of explicit calls to an operator:
>
>      (gdb) p operator==(s1,s2)
>      A syntax error in expression, near `operator==(s1,s2)'.
>
> The bug is that the name_not_typename production does not handle
> operator.
>
> This patch fixes the problem and adds a couple new test cases -- one for
> the bug and one for an explicit call to an operator as a member
> function; I couldn't find one of these in the test suite.
>
> Built and regtested on x86-64 (compile farm).
> Ok?
>

Yes, please commit.

  reply	other threads:[~2010-01-27 18:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-27 18:23 Tom Tromey
2010-01-27 18:37 ` Sami Wagiaalla [this message]
2010-01-27 19:26   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B6088BA.8080305@redhat.com \
    --to=swagiaal@redhat.com \
    --cc=archer@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).