From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3647 invoked by alias); 27 Jan 2010 19:15:45 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 3635 invoked by uid 22791); 27 Jan 2010 19:15:45 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Message-ID: <4B6090D8.3030801@redhat.com> Date: Wed, 27 Jan 2010 19:15:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Lightning/1.0pre Thunderbird/3.0 MIME-Version: 1.0 To: jan.kratochvil@redhat.com CC: archer@sourceware.org Subject: Re: [expr] [patch] Fix AAA::ALPHA regression after FSF GDB merge References: <20100127183304.GA26383@host0.dyn.jankratochvil.net> <4B608BCB.7070001@redhat.com> In-Reply-To: <4B608BCB.7070001@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2010-q1/txt/msg00037.txt.bz2 On 01/27/2010 10:54 AM, Sami Wagiaalla wrote: > On 01/27/2010 01:33 PM, Jan Kratochvil wrote: >> The patch below in fact exactly reverts a change of [expr-cumulative]. >> > > A change by Keith ? If so then maybe he has some concerns. Probably that > linkage name is being used during lookup not that it is being set here. > >> OK to check-in? >> >> No regressions on {x86_64,x86_64-m32,i686}-fedora12-linux-gnu. >> > > Okay by me if keith has no objections I think that the change that I made (from May 2009) from dwarf2_full_name was probably a workaround to a problem that has since been solved. Since your patch causes no regressions in realcpp.exp, I would say that your patch should be committed. Thanks! Keith