From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32306 invoked by alias); 3 Feb 2010 02:25:13 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 32296 invoked by uid 22791); 3 Feb 2010 02:25:12 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Message-ID: <4B68DE7E.2020802@redhat.com> Date: Wed, 03 Feb 2010 02:25:00 -0000 From: Chris Moller User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2 MIME-Version: 1.0 To: archer@sourceware.org Subject: Re: patch for pr9067 References: <4B68A35E.2050301@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2010-q1/txt/msg00048.txt.bz2 On 02/02/10 18:28, Tom Tromey wrote: >>>>>> "Chris" == Chris Moller writes: >>>>>> > > Chris> I just sent $subject to gdb-patches. > > Thanks. > > Chris> Turns out it was simultaneously more complex and simpler than we > Chris> both thought: You can't just blindly inhibit multiple printings > Chris> of static members. Sometimes it's legitimate, like when they > Chris> legitimately appear multiple times, possibly on different paths > Chris> through the tree. > > I didn't see this in the test case you sent. > Could you add it? > Sure, I can add it, but there are a handful of existing test cases that already cover that circumstance--I found them the hard way when my simplistic first-pas "fix" kept filtering out legitimate instances. > Chris> Not that I'm a big fan of obstacks, but on the > Chris> least-tinkering-possible principle, I scrapped my new stuff and > Chris> fixed the obstacks. > > Yeah, that's the right thing to do. > > Tom >