From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10538 invoked by alias); 5 Feb 2010 00:29:35 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 10528 invoked by uid 22791); 5 Feb 2010 00:29:35 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Message-ID: <4B6B6659.4020805@redhat.com> Date: Fri, 05 Feb 2010 00:29:00 -0000 From: Chris Moller User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2 MIME-Version: 1.0 To: Tom Tromey CC: Daniel Jacobowitz , Roland McGrath , Project Archer Subject: Re: PR 11067 References: <4B68A35E.2050301@redhat.com> <4B68DC25.1090808@redhat.com> <4B69F028.9070006@redhat.com> <20100203224239.04338AA@magilla.sf.frob.com> <20100203231408.GA6397@caradoc.them.org> <20100203232506.B073AAA@magilla.sf.frob.com> <20100203232819.GK9493@caradoc.them.org> <4B6A07E0.6020306@redhat.com> <4B6B041A.4030307@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2010-q1/txt/msg00066.txt.bz2 On 02/04/10 18:53, Tom Tromey wrote: > Chris> Just FYI, this patch breaks a handful of existing tests: > Chris> gdb.base/setvar.exp > Chris> gdb.cp/classes.exp > Chris> gdb.cp/m-data.exp > Chris> gdb.cp/m-static.exp > Chris> cp/namespace.exp > Chris> gdb.mi/mi-var-display.exp > Chris> gdb.python/py-value.exp > > Yeah. > > Chris> None of them are hard to fix in the expects--I just wanted The World > Chris> to realise that there are going to be noticeable consequences to this > Chris> fairly minor nicety. It'll take me a bit to fix the t/cs--if The > Chris> Powers That Be would rather this patch not proceed, I'd appreciate it > Chris> if you'd let me know sooner rather than later and spare me all the > Chris> fix-up work. > > Usually you just have to do it and see what happens. Even if we all > agree on a format here, someone else might disagree on gdb-patches, or > they might think of some new reason for it to be different. > > I, personally, want some form of this change, because every time I type > "p FOO" and get "$1 = FOO", I think, grrr, gdb could have told me what I > really wanted to know. If enough people dislike it we can always add > 'set print blah blah'. > Based on what people were saying yesterday, I thought I'd go with $1 = Val1=(enum E)56 It looks like a legitimate C expression. Lacking spaces, it's cohesive, and it's easily understood to present the same information in multiple formats. > Tom >