From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7856 invoked by alias); 22 Feb 2010 16:37:28 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 7837 invoked by uid 22791); 22 Feb 2010 16:37:25 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Message-ID: <4B82B22E.7050101@redhat.com> Date: Mon, 22 Feb 2010 16:37:00 -0000 From: Sami Wagiaalla User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Thunderbird/3.0.1 MIME-Version: 1.0 To: Project Archer Subject: Re: [rfc] patch for pr8880 References: <4B703D65.302@redhat.com> <4B71B645.2050806@redhat.com> <4B7D9890.1070607@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2010-q1/txt/msg00082.txt.bz2 On 02/19/2010 06:23 PM, Tom Tromey wrote: >>>>>> "Sami" == Sami Wagiaalla writes: > > Sami> Is it correct to assume then that qualified names should be treated > Sami> through evaluation of OP_SCOPE and is not effected by this patch - > Sami> baring lexer/parser bugs. Especially since the patch is now restricted > Sami> to user defined operators. > > Yes, I think that is a reasonable goal. > > It is mostly true now, except that "::name" is not emitted as OP_SCOPE. > I think it probably ought to be. > > Sami> +value_user_defined_adl_op (struct value **args, int nargs, char *operator) > Want me to work on that or are you already doing it ? > The new functions should be static. They need intro comments, as well. > > On trunk, you'll want to make 'operator' const; I don't know if that > little cleanup has made it to expr-cumulative yet. > > Sami> + arg_types = (struct type **)alloca (nargs * (sizeof (struct type *))); > > Missing a space before alloca. > > I think this looks good; check it in with those little changes. > Will do. Thanks. > Once Keith's big physname series goes in, I think we should push all the > remaining expr-cumulative stuff upstream, then shut down the branch and > do small fixes like this directly on trunk. For bigger fixes we can > still make a branch. I'll handle whatever stuff I've pushed on the > branch. Yup, I am working on that for my patches.