From: sami wagiaalla <swagiaal@redhat.com>
To: archer@sourceware.org
Subject: Re: [inferior events] cleanups in evpy_emit_event
Date: Wed, 15 Dec 2010 15:43:00 -0000 [thread overview]
Message-ID: <4D08E215.8070609@redhat.com> (raw)
In-Reply-To: <m3r5dkox5o.fsf@fleche.redhat.com>
On 12/14/2010 04:35 PM, Tom Tromey wrote:
> Sami --
>
> This patch cleans up evpy_emit_event:
>
> * It isn't ok to call error here
> * Now we check all Python operations
> * Now we call gdbpy_print_stack on error. This seems correct since
> we don't actually want errors here to propagate -- just to be printed
> if the user asked for that
> * Now objects are properly deallocated
>
Great! Thanks for the cleanup. I didn't really know how to report an
error but not propagate it.
> Ok to push?
Yes.
prev parent reply other threads:[~2010-12-15 15:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 21:35 Tom Tromey
2010-12-15 15:43 ` sami wagiaalla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D08E215.8070609@redhat.com \
--to=swagiaal@redhat.com \
--cc=archer@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).