From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30918 invoked by alias); 15 Dec 2010 15:57:59 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 30909 invoked by uid 22791); 15 Dec 2010 15:57:58 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Message-ID: <4D08E57D.4000200@redhat.com> Date: Wed, 15 Dec 2010 15:57:00 -0000 From: sami wagiaalla User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.8) Gecko/20100806 Fedora/3.1.2-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.2 MIME-Version: 1.0 To: Tom Tromey CC: Project Archer Subject: Re: [[inferior events] partial cleanup for copy_py_list References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2010-q4/txt/msg00041.txt.bz2 On 12/14/2010 04:41 PM, Tom Tromey wrote: > This fixes some issues in copy_py_list, but not all. > > The patch changes it to check PyList_Append. > > I think it should probably use an iterator to go through the list. > Otherwise it is susceptible to a bug where another thread changes the > list while we are iterating over it. > Hmm I did not know we had the option of using a safe iterator. If we do then that eliminates the need for copy_py_list in the first place; copy_py_list is used to make the call back of listeners safe against one listener editing the list during the iteration by removing an element. > Still, ok to push in this form? > Yes. And thanks for the cleanups. Sami