From: Keith Seitz <keiths@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: archer@sourceware.org
Subject: Re: Stop the Insanity! Linespec Rewrite
Date: Fri, 02 Mar 2012 22:41:00 -0000 [thread overview]
Message-ID: <4F514C89.3000406@redhat.com> (raw)
In-Reply-To: <874nu7c51b.fsf@fleche.redhat.com>
On 03/02/2012 08:59 AM, Tom Tromey wrote:
> Keith> o We now have a (trivial) parser and a lexer. The lexer "word" breaks
> Keith> the input on ':', but it does know about "::" as a scope operator for
> Keith> C++ (but nothing on ObjC).
>
> From reading the code I had a feeling that a leading ":" wasn't handled
> properly. So I tried it, and `b ::foo' causes an internal error.
Doh! I can't believe there is no existing test for that! In any case,
I've got a patch for that.
> A couple other notes -
>
> linespec_parse_line_offset only allows decimal but the lexer allows hex.
> But why bother with hex?
That's a cleanup. I implemented that a loooong time ago, well, just
because I could. I'll remove that during the cleanup phase (along with
several other unnecessary things).
> I noticed the code is missing 'const' in a number of places.
I'll fix those.
> Keith> For example, you cannot do: "break
> Keith> klass::'operator +'" anymore.
>
> What is the issue with this one?
Not much, really. I could probably implement something to do it, but I
really view this whole quoting issue as a workaround for bugs in the old
linespec.c We don't/shouldn't really need that from here on out.
Let me know if you want me to add that back in.
> I saw the WHATS_THIS_FOR. I'm not sure what it is for, but on some
> platforms a symbol can start with "$", so maybe it is handling that
> case. You can maybe construct one with gcc -fdollars-in-identifiers.
I'll play with that and see if I can trigger this.
Thank you for taking a look!
Keith
next prev parent reply other threads:[~2012-03-02 22:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 1:14 Keith Seitz
2012-03-02 17:00 ` Tom Tromey
2012-03-02 22:41 ` Keith Seitz [this message]
2012-03-03 2:36 ` Tom Tromey
2012-03-02 19:07 ` [Archer] " Joel Brobecker
2012-03-02 22:49 ` Keith Seitz
2012-03-06 17:40 ` [Archer] " Joel Brobecker
2012-03-06 19:08 ` Keith Seitz
2012-03-06 19:36 ` Keith Seitz
2012-03-06 21:50 ` [Archer] " Joel Brobecker
2012-03-07 0:11 ` [Archer] " Joel Brobecker
2012-03-07 1:08 ` Keith Seitz
2012-03-07 1:26 ` [Archer] " Joel Brobecker
2012-03-07 14:39 ` Tom Tromey
2012-03-07 15:01 ` Tom Tromey
2012-03-07 15:39 ` [Archer] " Joel Brobecker
2012-03-07 16:06 ` Tom Tromey
2012-03-07 21:19 ` Joel Brobecker
2012-03-07 21:11 ` [Archer] " Keith Seitz
2012-03-08 3:02 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F514C89.3000406@redhat.com \
--to=keiths@redhat.com \
--cc=archer@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).