From: Keith Seitz <keiths@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: archer@sourceware.org
Subject: Re: [Archer] Re: [Archer] Stop the Insanity! Linespec Rewrite
Date: Tue, 06 Mar 2012 19:36:00 -0000 [thread overview]
Message-ID: <4F56671E.4000905@redhat.com> (raw)
In-Reply-To: <4F564C6F.60001@redhat.com>
On 03/06/2012 09:42 AM, Keith Seitz wrote:
>> If you'd like me to take a look and tell you what's going on, I'd be
>> more than happy to...
>
> I will take a look at this immediately. Thanks!
This turned out to be pretty simple. collect_symbols was unconditionally
adding all matching symbols to the results, which is appropriate only
with DECODE_LINE_LIST_MODE. [I admit, I didn't actually know one could
do that. "list a_global_variable" Learn something new everyday!]
I pushed a patch for this. It now passes all of your new tests.
Any others?
Keith
next prev parent reply other threads:[~2012-03-06 19:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 1:14 Keith Seitz
2012-03-02 17:00 ` Tom Tromey
2012-03-02 22:41 ` Keith Seitz
2012-03-03 2:36 ` Tom Tromey
2012-03-02 19:07 ` [Archer] " Joel Brobecker
2012-03-02 22:49 ` Keith Seitz
2012-03-06 17:40 ` [Archer] " Joel Brobecker
2012-03-06 19:08 ` Keith Seitz
2012-03-06 19:36 ` Keith Seitz [this message]
2012-03-06 21:50 ` [Archer] " Joel Brobecker
2012-03-07 0:11 ` [Archer] " Joel Brobecker
2012-03-07 1:08 ` Keith Seitz
2012-03-07 1:26 ` [Archer] " Joel Brobecker
2012-03-07 14:39 ` Tom Tromey
2012-03-07 15:01 ` Tom Tromey
2012-03-07 15:39 ` [Archer] " Joel Brobecker
2012-03-07 16:06 ` Tom Tromey
2012-03-07 21:19 ` Joel Brobecker
2012-03-07 21:11 ` [Archer] " Keith Seitz
2012-03-08 3:02 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F56671E.4000905@redhat.com \
--to=keiths@redhat.com \
--cc=archer@sourceware.org \
--cc=brobecker@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).