From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8839 invoked by alias); 6 Mar 2012 19:36:34 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 8723 invoked by uid 22791); 6 Mar 2012 19:36:33 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Message-ID: <4F56671E.4000905@redhat.com> Date: Tue, 06 Mar 2012 19:36:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Joel Brobecker CC: archer@sourceware.org Subject: Re: [Archer] Re: [Archer] Stop the Insanity! Linespec Rewrite References: <4F501EC1.3050104@redhat.com> <20120302190658.GH2867@adacore.com> <4F514E30.7070400@redhat.com> <20120306173945.GP2867@adacore.com> <4F564C6F.60001@redhat.com> In-Reply-To: <4F564C6F.60001@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2012-q1/txt/msg00022.txt.bz2 On 03/06/2012 09:42 AM, Keith Seitz wrote: >> If you'd like me to take a look and tell you what's going on, I'd be >> more than happy to... > > I will take a look at this immediately. Thanks! This turned out to be pretty simple. collect_symbols was unconditionally adding all matching symbols to the results, which is appropriate only with DECODE_LINE_LIST_MODE. [I admit, I didn't actually know one could do that. "list a_global_variable" Learn something new everyday!] I pushed a patch for this. It now passes all of your new tests. Any others? Keith