From: Keith Seitz <keiths@redhat.com>
To: archer@sourceware.org
Subject: New linespec error messages
Date: Tue, 13 Mar 2012 19:27:00 -0000 [thread overview]
Message-ID: <4F5F9FA7.2090907@redhat.com> (raw)
Hi,
I'm nearly finished cleaning up my linespec rewrite. I have an enormous
amount of bugs that I've fixed while writing some tests for it.
One thing that has evolved out of this work, though, is the ability to
provide "better" error messages for the user. For example:
(gdb-head) b main.c:
Function "" not defined in "main.c".
(gdb-linespec-rewrite) b main.c:
malformed linespec error: unexpected EOF
Similarly, for other possible error conditions, my rewrite will
(currently) output error messages such as:
malfomred linespec error: unexpected TOKEN[, "TOKEN_STRING"]
where TOKEN is one of the token types ("keyword", "string", "number",
"EOF", "COLON", etc) and TOKEN_STRING is a string representation of what
the user wrote. Here's another example:
(gdb-head) break main.c:3 +1000
Junk at end of arguments.
(gdb-linespec-rewrite) b main.c:3 +1000
malformed linespec error: unexpected number, "+1000"
Does anyone have any input on the text of these error messages? Any
changes that maintainers might like?
Keith
next reply other threads:[~2012-03-13 19:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 19:27 Keith Seitz [this message]
2012-03-13 20:18 ` [Archer] " Joel Brobecker
2012-03-16 13:38 ` Daniel Jacobowitz
2012-03-16 14:12 ` Keith Seitz
2012-03-17 3:36 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5F9FA7.2090907@redhat.com \
--to=keiths@redhat.com \
--cc=archer@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).