From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1953 invoked by alias); 13 Mar 2012 19:27:57 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 1941 invoked by uid 22791); 13 Mar 2012 19:27:55 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Message-ID: <4F5F9FA7.2090907@redhat.com> Date: Tue, 13 Mar 2012 19:27:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: archer@sourceware.org Subject: New linespec error messages Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2012-q1/txt/msg00034.txt.bz2 Hi, I'm nearly finished cleaning up my linespec rewrite. I have an enormous amount of bugs that I've fixed while writing some tests for it. One thing that has evolved out of this work, though, is the ability to provide "better" error messages for the user. For example: (gdb-head) b main.c: Function "" not defined in "main.c". (gdb-linespec-rewrite) b main.c: malformed linespec error: unexpected EOF Similarly, for other possible error conditions, my rewrite will (currently) output error messages such as: malfomred linespec error: unexpected TOKEN[, "TOKEN_STRING"] where TOKEN is one of the token types ("keyword", "string", "number", "EOF", "COLON", etc) and TOKEN_STRING is a string representation of what the user wrote. Here's another example: (gdb-head) break main.c:3 +1000 Junk at end of arguments. (gdb-linespec-rewrite) b main.c:3 +1000 malformed linespec error: unexpected number, "+1000" Does anyone have any input on the text of these error messages? Any changes that maintainers might like? Keith