New linespec error messages

New linespec error messages

[Keith Seitz]

Hi,

I'm nearly finished cleaning up my linespec rewrite. I have an enormous 
amount of bugs that I've fixed while writing some tests for it.

One thing that has evolved out of this work, though, is the ability to 
provide "better" error messages for the user. For example:

(gdb-head) b main.c:
Function "" not defined in "main.c".

(gdb-linespec-rewrite) b main.c:
malformed linespec error: unexpected EOF

Similarly, for other possible error conditions, my rewrite will 
(currently) output error messages such as:

malfomred linespec error: unexpected TOKEN[, "TOKEN_STRING"]

where TOKEN is one of the token types ("keyword", "string", "number", 
"EOF", "COLON", etc) and TOKEN_STRING is a string representation of what 
the user wrote. Here's another example:

(gdb-head) break main.c:3 +1000
Junk at end of arguments.

(gdb-linespec-rewrite) b main.c:3 +1000
malformed linespec error: unexpected number, "+1000"

Does anyone have any input on the text of these error messages? Any 
changes that maintainers might like?

Keith

Re: [Archer] New linespec error messages

[Joel Brobecker]

> Does anyone have any input on the text of these error messages? Any
> changes that maintainers might like?

I say, this looks pretty nice! The error message "unexpected EOF"
might be a little cryptic to a newcomer, but overall, neat!

-- 
Joel

Re: [Archer] New linespec error messages

[Daniel Jacobowitz]

On Tue, Mar 13, 2012 at 4:17 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>
> > Does anyone have any input on the text of these error messages? Any
> > changes that maintainers might like?
>
> I say, this looks pretty nice! The error message "unexpected EOF"
> might be a little cryptic to a newcomer, but overall, neat!

I agree; it's not an EOF, anyway.  "unexpected end of line"?

I'm super excited to see the last of "Junk at end of arguments"!

--
Thanks,
Daniel

Re: [Archer] New linespec error messages

[Keith Seitz]

On 03/16/2012 06:38 AM, Daniel Jacobowitz wrote:
> On Tue, Mar 13, 2012 at 4:17 PM, Joel Brobecker<brobecker@adacore.com>  wrote:
>>
>>> Does anyone have any input on the text of these error messages? Any
>>> changes that maintainers might like?
>>
>> I say, this looks pretty nice! The error message "unexpected EOF"
>> might be a little cryptic to a newcomer, but overall, neat!
>
> I agree; it's not an EOF, anyway.  "unexpected end of line"?

I wasn't either. I have already committed a change to this for 
"unexpected end of input".

So the question of the minute is, "line" or "input"? [I figure to try to 
get at least some of the trivia mostly settled by the time I submit the 
patch Very Soon Now (TM).

Keith

Re: [Archer] New linespec error messages

[Daniel Jacobowitz]

On Fri, Mar 16, 2012 at 10:12 AM, Keith Seitz <keiths@redhat.com> wrote:
> On 03/16/2012 06:38 AM, Daniel Jacobowitz wrote:
>>
>> On Tue, Mar 13, 2012 at 4:17 PM, Joel Brobecker<brobecker@adacore.com>
>>  wrote:
>>>
>>>
>>>> Does anyone have any input on the text of these error messages? Any
>>>> changes that maintainers might like?
>>>
>>>
>>> I say, this looks pretty nice! The error message "unexpected EOF"
>>> might be a little cryptic to a newcomer, but overall, neat!
>>
>>
>> I agree; it's not an EOF, anyway.  "unexpected end of line"?
>
>
> I wasn't either. I have already committed a change to this for "unexpected
> end of input".
>
> So the question of the minute is, "line" or "input"? [I figure to try to get
> at least some of the trivia mostly settled by the time I submit the patch
> Very Soon Now (TM).

I like both options :-)

-- 
Thanks,
Daniel