From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19536 invoked by alias); 14 Oct 2013 19:27:05 -0000 Mailing-List: contact archer-help@sourceware.org; run by ezmlm Sender: Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Received: (qmail 19516 invoked by uid 89); 14 Oct 2013 19:27:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Message-ID: <525C4584.1030202@redhat.com> Date: Mon, 14 Oct 2013 19:27:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: Tom Tromey CC: archer@sourceware.org Subject: Re: archer/tromey patches left to merge References: <525BD4EA.60907@redhat.com> <87siw33ol6.fsf@fleche.redhat.com> In-Reply-To: <87siw33ol6.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-q4/txt/msg00004.txt.bz2 On 14/10/13 15:37, Tom Tromey wrote: > Phil> * gdb.cli() command. > [...] Thanks for the reply Tom. Here is my plan, pending other comments. * Merge caller_is and caller_matches functions. I will keep them as two separate functions. My first thought was to achieve the results of both with optional keyword arguments, but after investigating a little this would probably end up with a function heavily loaded with conditional keyword arguments. It removes simplicity and adds complexity, so going with how it stands now. I will add the option to search the entire stack. I will need to write tests and documentation for both. * Merge -P and gdb.cli() These two patches will be merged as one submission as they seem to be complimentary in a use-case sense. I will need to write tests and documentation for both. The -P tests and the gdb.cli() tests seem to be non-trivial in the GDB test suite. * Merge ignore_errors command. Tom provided a case that it is needed. Needs tests and documentation. * Merge in_scope function. I think this is useful, so I will port it. Needs test and documentation. (As an aside, I am not sure where we should document these python only functions. Will discuss.) * Merge pahole command. I am not sure how to make this language agnostic, or even how to make it complimentary with ptype. (We will discuss this more when the time-slot arrives in my schedule to consider the effort of porting it). That's the order I intend to work on them as time allows. Lastly, I will delete the defunct code orphans and remove the obsoleted commands from the branch. Cheers, Phil